Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ata: pata_serverworks: Do not use the term blacklist

Let's not use the term blacklist in the function
serverworks_osb4_filter() documentation comment and rather simply refer
to what that function looks at: the list of devices with groken UDMA5.

While at it, also constify the values of the csb_bad_ata100 array.

Of note is that all of this should probably be handled using libata
quirk mechanism but it is unclear if these UDMA5 quirks are specific
to this controller only.

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Igor Pylypiv <ipylypiv@google.com>

+9 -7
+9 -7
drivers/ata/pata_serverworks.c
··· 46 46 #define SVWKS_CSB5_REVISION_NEW 0x92 /* min PCI_REVISION_ID for UDMA5 (A2.0) */ 47 47 #define SVWKS_CSB6_REVISION 0xa0 /* min PCI_REVISION_ID for UDMA4 (A1.0) */ 48 48 49 - /* Seagate Barracuda ATA IV Family drives in UDMA mode 5 50 - * can overrun their FIFOs when used with the CSB5 */ 51 - 52 - static const char *csb_bad_ata100[] = { 49 + /* 50 + * Seagate Barracuda ATA IV Family drives in UDMA mode 5 51 + * can overrun their FIFOs when used with the CSB5. 52 + */ 53 + static const char * const csb_bad_ata100[] = { 53 54 "ST320011A", 54 55 "ST340016A", 55 56 "ST360021A", ··· 164 163 * @adev: ATA device 165 164 * @mask: Mask of proposed modes 166 165 * 167 - * Check the blacklist and disable UDMA5 if matched 166 + * Check the list of devices with broken UDMA5 and 167 + * disable UDMA5 if matched. 168 168 */ 169 - 170 - static unsigned int serverworks_csb_filter(struct ata_device *adev, unsigned int mask) 169 + static unsigned int serverworks_csb_filter(struct ata_device *adev, 170 + unsigned int mask) 171 171 { 172 172 const char *p; 173 173 char model_num[ATA_ID_PROD_LEN + 1];