Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] include: update jiffies/{m,u}secs conversion functions

Clarify the human-time units to jiffies conversion functions by using the
constants in time.h. This makes many of the subsequent patches direct
copies of the current code.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by

Nishanth Aravamudan and committed by
Linus Torvalds
84f902c0 64ed93a2

+22 -20
+20 -20
include/linux/jiffies.h
··· 254 254 */ 255 255 static inline unsigned int jiffies_to_msecs(const unsigned long j) 256 256 { 257 - #if HZ <= 1000 && !(1000 % HZ) 258 - return (1000 / HZ) * j; 259 - #elif HZ > 1000 && !(HZ % 1000) 260 - return (j + (HZ / 1000) - 1)/(HZ / 1000); 257 + #if HZ <= MSEC_PER_SEC && !(MSEC_PER_SEC % HZ) 258 + return (MSEC_PER_SEC / HZ) * j; 259 + #elif HZ > MSEC_PER_SEC && !(HZ % MSEC_PER_SEC) 260 + return (j + (HZ / MSEC_PER_SEC) - 1)/(HZ / MSEC_PER_SEC); 261 261 #else 262 - return (j * 1000) / HZ; 262 + return (j * MSEC_PER_SEC) / HZ; 263 263 #endif 264 264 } 265 265 266 266 static inline unsigned int jiffies_to_usecs(const unsigned long j) 267 267 { 268 - #if HZ <= 1000000 && !(1000000 % HZ) 269 - return (1000000 / HZ) * j; 270 - #elif HZ > 1000000 && !(HZ % 1000000) 271 - return (j + (HZ / 1000000) - 1)/(HZ / 1000000); 268 + #if HZ <= USEC_PER_SEC && !(USEC_PER_SEC % HZ) 269 + return (USEC_PER_SEC / HZ) * j; 270 + #elif HZ > USEC_PER_SEC && !(HZ % USEC_PER_SEC) 271 + return (j + (HZ / USEC_PER_SEC) - 1)/(HZ / USEC_PER_SEC); 272 272 #else 273 - return (j * 1000000) / HZ; 273 + return (j * USEC_PER_SEC) / HZ; 274 274 #endif 275 275 } 276 276 ··· 278 278 { 279 279 if (m > jiffies_to_msecs(MAX_JIFFY_OFFSET)) 280 280 return MAX_JIFFY_OFFSET; 281 - #if HZ <= 1000 && !(1000 % HZ) 282 - return (m + (1000 / HZ) - 1) / (1000 / HZ); 283 - #elif HZ > 1000 && !(HZ % 1000) 284 - return m * (HZ / 1000); 281 + #if HZ <= MSEC_PER_SEC && !(MSEC_PER_SEC % HZ) 282 + return (m + (MSEC_PER_SEC / HZ) - 1) / (MSEC_PER_SEC / HZ); 283 + #elif HZ > MSEC_PER_SEC && !(HZ % MSEC_PER_SEC) 284 + return m * (HZ / MSEC_PER_SEC); 285 285 #else 286 - return (m * HZ + 999) / 1000; 286 + return (m * HZ + MSEC_PER_SEC - 1) / MSEC_PER_SEC; 287 287 #endif 288 288 } 289 289 ··· 291 291 { 292 292 if (u > jiffies_to_usecs(MAX_JIFFY_OFFSET)) 293 293 return MAX_JIFFY_OFFSET; 294 - #if HZ <= 1000000 && !(1000000 % HZ) 295 - return (u + (1000000 / HZ) - 1) / (1000000 / HZ); 296 - #elif HZ > 1000000 && !(HZ % 1000000) 297 - return u * (HZ / 1000000); 294 + #if HZ <= USEC_PER_SEC && !(USEC_PER_SEC % HZ) 295 + return (u + (USEC_PER_SEC / HZ) - 1) / (USEC_PER_SEC / HZ); 296 + #elif HZ > USEC_PER_SEC && !(HZ % USEC_PER_SEC) 297 + return u * (HZ / USEC_PER_SEC); 298 298 #else 299 - return (u * HZ + 999999) / 1000000; 299 + return (u * HZ + USEC_PER_SEC - 1) / USEC_PER_SEC; 300 300 #endif 301 301 } 302 302
+2
include/linux/time.h
··· 28 28 #ifdef __KERNEL__ 29 29 30 30 /* Parameters used to convert the timespec values */ 31 + #define MSEC_PER_SEC (1000L) 32 + 31 33 #ifndef USEC_PER_SEC 32 34 #define USEC_PER_SEC (1000000L) 33 35 #endif