Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

qlge: Fix incorrect usage of module parameters and netdev msg level

Driver appears to be mistaking the permission field with default value
in the case of debug and qlge_irq_type.

Driver is also passing debug as a bitmask into netif_msg_init()
which wants a number of bits. Ron Mercer suggests we should
change this to pass in -1 so the defaults get used instead,
which makes the default much less verbose.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Sonny Rao and committed by
David S. Miller
84cf7029 88b2a9a3

+3 -3
+3 -3
drivers/net/qlge/qlge_main.c
··· 62 62 /* NETIF_MSG_PKTDATA | */ 63 63 NETIF_MSG_HW | NETIF_MSG_WOL | 0; 64 64 65 - static int debug = 0x00007fff; /* defaults above */ 66 - module_param(debug, int, 0); 65 + static int debug = -1; /* defaults above */ 66 + module_param(debug, int, 0664); 67 67 MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)"); 68 68 69 69 #define MSIX_IRQ 0 70 70 #define MSI_IRQ 1 71 71 #define LEG_IRQ 2 72 72 static int qlge_irq_type = MSIX_IRQ; 73 - module_param(qlge_irq_type, int, MSIX_IRQ); 73 + module_param(qlge_irq_type, int, 0664); 74 74 MODULE_PARM_DESC(qlge_irq_type, "0 = MSI-X, 1 = MSI, 2 = Legacy."); 75 75 76 76 static int qlge_mpi_coredump;