Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm: Unexport drm_plane_helper_check_update

It's for legacy drivers only (atomic ones should use
drm_atomic_helper_check_plane_state() instead), and there's no users
left except the one in the primary plane helpers.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181004202446.22905-18-daniel.vetter@ffwll.ch

+11 -49
+11 -38
drivers/gpu/drm/drm_plane_helper.c
··· 97 97 return count; 98 98 } 99 99 100 - /** 101 - * drm_plane_helper_check_update() - Check plane update for validity 102 - * @plane: plane object to update 103 - * @crtc: owning CRTC of owning plane 104 - * @fb: framebuffer to flip onto plane 105 - * @src: source coordinates in 16.16 fixed point 106 - * @dst: integer destination coordinates 107 - * @rotation: plane rotation 108 - * @min_scale: minimum @src:@dest scaling factor in 16.16 fixed point 109 - * @max_scale: maximum @src:@dest scaling factor in 16.16 fixed point 110 - * @can_position: is it legal to position the plane such that it 111 - * doesn't cover the entire crtc? This will generally 112 - * only be false for primary planes. 113 - * @can_update_disabled: can the plane be updated while the crtc 114 - * is disabled? 115 - * @visible: output parameter indicating whether plane is still visible after 116 - * clipping 117 - * 118 - * Checks that a desired plane update is valid. Drivers that provide 119 - * their own plane handling rather than helper-provided implementations may 120 - * still wish to call this function to avoid duplication of error checking 121 - * code. 122 - * 123 - * RETURNS: 124 - * Zero if update appears valid, error code on failure 125 - */ 126 - int drm_plane_helper_check_update(struct drm_plane *plane, 127 - struct drm_crtc *crtc, 128 - struct drm_framebuffer *fb, 129 - struct drm_rect *src, 130 - struct drm_rect *dst, 131 - unsigned int rotation, 132 - int min_scale, 133 - int max_scale, 134 - bool can_position, 135 - bool can_update_disabled, 136 - bool *visible) 100 + static int drm_plane_helper_check_update(struct drm_plane *plane, 101 + struct drm_crtc *crtc, 102 + struct drm_framebuffer *fb, 103 + struct drm_rect *src, 104 + struct drm_rect *dst, 105 + unsigned int rotation, 106 + int min_scale, 107 + int max_scale, 108 + bool can_position, 109 + bool can_update_disabled, 110 + bool *visible) 137 111 { 138 112 struct drm_plane_state plane_state = { 139 113 .plane = plane, ··· 144 170 145 171 return 0; 146 172 } 147 - EXPORT_SYMBOL(drm_plane_helper_check_update); 148 173 149 174 static int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc, 150 175 struct drm_framebuffer *fb,
-11
include/drm/drm_plane_helper.h
··· 38 38 */ 39 39 #define DRM_PLANE_HELPER_NO_SCALING (1<<16) 40 40 41 - int drm_plane_helper_check_update(struct drm_plane *plane, 42 - struct drm_crtc *crtc, 43 - struct drm_framebuffer *fb, 44 - struct drm_rect *src, 45 - struct drm_rect *dest, 46 - unsigned int rotation, 47 - int min_scale, 48 - int max_scale, 49 - bool can_position, 50 - bool can_update_disabled, 51 - bool *visible); 52 41 void drm_primary_helper_destroy(struct drm_plane *plane); 53 42 extern const struct drm_plane_funcs drm_primary_helper_funcs; 54 43