Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] cx88: notch filter control fixes

This patch reduces the number of available choices for the notch filter type control
so that the standard-specific filter types cannot be selected. It is now limited to
being either 0 (4xFsc, the default) or 1 (square pixel optimized).
The patch also removes the initialization of this control from cx88_reset(), since
that is already done by init_controls(), which is called by cx8800_initdev().

Signed-off-by: Istvan Varga <istvan_v@mailbox.hu>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

istvan_v@mailbox.hu and committed by
Mauro Carvalho Chehab
84b27148 2b50763a

+1 -4
-3
drivers/media/video/cx88/cx88-core.c
··· 636 636 cx_write(MO_PCI_INTSTAT, 0xFFFFFFFF); // Clear PCI int 637 637 cx_write(MO_INT1_STAT, 0xFFFFFFFF); // Clear RISC int 638 638 639 - /* set default notch filter */ 640 - cx_andor(MO_HTOTAL, 0x1800, (HLNotchFilter4xFsc << 11)); 641 - 642 639 /* Reset on-board parts */ 643 640 cx_write(MO_SRST_IO, 0); 644 641 msleep(10);
+1 -1
drivers/media/video/cx88/cx88-video.c
··· 266 266 .id = V4L2_CID_BAND_STOP_FILTER, 267 267 .name = "Notch filter", 268 268 .minimum = 0, 269 - .maximum = 3, 269 + .maximum = 1, 270 270 .step = 1, 271 271 .default_value = 0x0, 272 272 .type = V4L2_CTRL_TYPE_INTEGER,