Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: phy: mxs: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Frank Li <Frank.li@nxp.com>
Link: https://lore.kernel.org/r/20230319092428.283054-9-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Uwe Kleine-König and committed by
Greg Kroah-Hartman
8471b0fa 25b979e4

+2 -4
+2 -4
drivers/usb/phy/phy-mxs-usb.c
··· 801 801 return usb_add_phy_dev(&mxs_phy->phy); 802 802 } 803 803 804 - static int mxs_phy_remove(struct platform_device *pdev) 804 + static void mxs_phy_remove(struct platform_device *pdev) 805 805 { 806 806 struct mxs_phy *mxs_phy = platform_get_drvdata(pdev); 807 807 808 808 usb_remove_phy(&mxs_phy->phy); 809 - 810 - return 0; 811 809 } 812 810 813 811 #ifdef CONFIG_PM_SLEEP ··· 851 853 852 854 static struct platform_driver mxs_phy_driver = { 853 855 .probe = mxs_phy_probe, 854 - .remove = mxs_phy_remove, 856 + .remove_new = mxs_phy_remove, 855 857 .driver = { 856 858 .name = DRIVER_NAME, 857 859 .of_match_table = mxs_phy_dt_ids,