Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

staging: vchiq_core: fix quoted strings split across lines

Quoted strings should not be split across lines. As put it in [1]:
"never break user-visible strings such as printk messages because that
breaks the ability to grep for them."

While at it, fix the alignment of the arguments in the sentence.

Note: this introduce a checkpatch CHECK: line length of 123 exceeds 100
columns, as the line now is:

vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)",

But now the string is grep-able and the whole function call more
clear.

Reported by checkpatch.pl

[1] Documentation/process/coding-style.rst

Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
Link: https://lore.kernel.org/r/20211024213839.370830-1-gascoar@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Gaston Gonzalez and committed by
Greg Kroah-Hartman
846bf13d 6ab92ea6

+3 -7
+3 -7
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
··· 1499 1499 if ((service->version < version_min) || (version < service->version_min)) { 1500 1500 /* Version mismatch */ 1501 1501 vchiq_loud_error_header(); 1502 - vchiq_loud_error("%d: service %d (%c%c%c%c) " 1503 - "version mismatch - local (%d, min %d)" 1504 - " vs. remote (%d, min %d)", 1505 - state->id, service->localport, 1506 - VCHIQ_FOURCC_AS_4CHARS(fourcc), 1507 - service->version, service->version_min, 1508 - version, version_min); 1502 + vchiq_loud_error("%d: service %d (%c%c%c%c) version mismatch - local (%d, min %d) vs. remote (%d, min %d)", 1503 + state->id, service->localport, VCHIQ_FOURCC_AS_4CHARS(fourcc), 1504 + service->version, service->version_min, version, version_min); 1509 1505 vchiq_loud_error_footer(); 1510 1506 vchiq_service_put(service); 1511 1507 service = NULL;