Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: add add_disk() error handling

We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/20211015233028.2167651-10-mcgrof@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Luis Chamberlain and committed by
Jens Axboe
83b863f4 2e9e31be

+5 -1
+5 -1
drivers/mtd/mtd_blkdevs.c
··· 384 384 if (new->readonly) 385 385 set_disk_ro(gd, 1); 386 386 387 - device_add_disk(&new->mtd->dev, gd, NULL); 387 + ret = device_add_disk(&new->mtd->dev, gd, NULL); 388 + if (ret) 389 + goto out_cleanup_disk; 388 390 389 391 if (new->disk_attributes) { 390 392 ret = sysfs_create_group(&disk_to_dev(gd)->kobj, ··· 395 393 } 396 394 return 0; 397 395 396 + out_cleanup_disk: 397 + blk_cleanup_disk(new->disk); 398 398 out_free_tag_set: 399 399 blk_mq_free_tag_set(new->tag_set); 400 400 out_kfree_tag_set: