Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iommu/vt-d: Use kcalloc() instead of kzalloc()

This is an effort to get rid of all multiplications from allocation
functions in order to prevent integer overflows [1].

Here the multiplication is obviously safe because DMAR_LATENCY_NUM
is the number of latency types defined in the "latency_type" enum.

enum latency_type {
DMAR_LATENCY_INV_IOTLB = 0,
DMAR_LATENCY_INV_DEVTLB,
DMAR_LATENCY_INV_IEC,
DMAR_LATENCY_PRQ,
DMAR_LATENCY_NUM
};

However, using kcalloc() is more appropriate [2] and improves
readability. This patch has no effect on runtime behavior.

Link: https://github.com/KSPP/linux/issues/162 [1]
Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [2]
Signed-off-by: Erick Archer <erick.archer@gmx.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20240211175143.9229-1-erick.archer@gmx.com
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

authored by

Erick Archer and committed by
Joerg Roedel
83790548 4b8d18c0

+1 -1
+1 -1
drivers/iommu/intel/perf.c
··· 33 33 34 34 spin_lock_irqsave(&latency_lock, flags); 35 35 if (!iommu->perf_statistic) { 36 - iommu->perf_statistic = kzalloc(sizeof(*lstat) * DMAR_LATENCY_NUM, 36 + iommu->perf_statistic = kcalloc(DMAR_LATENCY_NUM, sizeof(*lstat), 37 37 GFP_ATOMIC); 38 38 if (!iommu->perf_statistic) { 39 39 ret = -ENOMEM;