misc: mic: Fix for double fetch security bug in VOP driver

The MIC VOP driver does two successive reads from user space to read a
variable length data structure. Kernel memory corruption can result if
the data structure changes between the two reads. This patch disallows
the chance of this happening.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116651
Reported by: Pengfei Wang <wpengfeinudt@gmail.com>
Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by Ashutosh Dixit and committed by Greg Kroah-Hartman 82dc4afd c3b46c73

Changed files
+5
drivers
misc
mic
+5
drivers/misc/mic/vop/vop_vringh.c
··· 945 945 ret = -EFAULT; 946 946 goto free_ret; 947 947 } 948 + /* Ensure desc has not changed between the two reads */ 949 + if (memcmp(&dd, dd_config, sizeof(dd))) { 950 + ret = -EINVAL; 951 + goto free_ret; 952 + } 948 953 mutex_lock(&vdev->vdev_mutex); 949 954 mutex_lock(&vi->vop_mutex); 950 955 ret = vop_virtio_add_device(vdev, dd_config);