Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: sd: Inline sd_probe_part2()

Make sd_probe() easier to read by inlining sd_probe_part2(). This patch
does not change any functionality.

[mkp: applied by hand]

Cc: Lee Duncan <lduncan@suse.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Bart Van Assche and committed by
Martin K. Petersen
82a54da6 f049cf1a

+44 -59
+44 -59
drivers/scsi/sd.c
··· 3254 3254 return 0; 3255 3255 } 3256 3256 3257 - static void sd_probe_part2(struct scsi_disk *sdkp) 3258 - { 3259 - struct scsi_device *sdp; 3260 - struct gendisk *gd; 3261 - u32 index; 3262 - struct device *dev; 3263 - 3264 - sdp = sdkp->device; 3265 - gd = sdkp->disk; 3266 - index = sdkp->index; 3267 - dev = &sdp->sdev_gendev; 3268 - 3269 - gd->major = sd_major((index & 0xf0) >> 4); 3270 - gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00); 3271 - 3272 - gd->fops = &sd_fops; 3273 - gd->private_data = &sdkp->driver; 3274 - gd->queue = sdkp->device->request_queue; 3275 - 3276 - /* defaults, until the device tells us otherwise */ 3277 - sdp->sector_size = 512; 3278 - sdkp->capacity = 0; 3279 - sdkp->media_present = 1; 3280 - sdkp->write_prot = 0; 3281 - sdkp->cache_override = 0; 3282 - sdkp->WCE = 0; 3283 - sdkp->RCD = 0; 3284 - sdkp->ATO = 0; 3285 - sdkp->first_scan = 1; 3286 - sdkp->max_medium_access_timeouts = SD_MAX_MEDIUM_TIMEOUTS; 3287 - 3288 - sd_revalidate_disk(gd); 3289 - 3290 - gd->flags = GENHD_FL_EXT_DEVT; 3291 - if (sdp->removable) { 3292 - gd->flags |= GENHD_FL_REMOVABLE; 3293 - gd->events |= DISK_EVENT_MEDIA_CHANGE; 3294 - gd->event_flags = DISK_EVENT_FLAG_POLL | DISK_EVENT_FLAG_UEVENT; 3295 - } 3296 - 3297 - blk_pm_runtime_init(sdp->request_queue, dev); 3298 - device_add_disk(dev, gd, NULL); 3299 - if (sdkp->capacity) 3300 - sd_dif_config_host(sdkp); 3301 - 3302 - sd_revalidate_disk(gd); 3303 - 3304 - if (sdkp->security) { 3305 - sdkp->opal_dev = init_opal_dev(sdp, &sd_sec_submit); 3306 - if (sdkp->opal_dev) 3307 - sd_printk(KERN_NOTICE, sdkp, "supports TCG Opal\n"); 3308 - } 3309 - 3310 - sd_printk(KERN_NOTICE, sdkp, "Attached SCSI %sdisk\n", 3311 - sdp->removable ? "removable " : ""); 3312 - scsi_autopm_put_device(sdp); 3313 - } 3314 - 3315 3257 /** 3316 3258 * sd_probe - called during driver initialization and whenever a 3317 3259 * new scsi device is attached to the system. It is called once ··· 3343 3401 get_device(dev); 3344 3402 dev_set_drvdata(dev, sdkp); 3345 3403 3346 - sd_probe_part2(sdkp); 3404 + gd->major = sd_major((index & 0xf0) >> 4); 3405 + gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00); 3406 + 3407 + gd->fops = &sd_fops; 3408 + gd->private_data = &sdkp->driver; 3409 + gd->queue = sdkp->device->request_queue; 3410 + 3411 + /* defaults, until the device tells us otherwise */ 3412 + sdp->sector_size = 512; 3413 + sdkp->capacity = 0; 3414 + sdkp->media_present = 1; 3415 + sdkp->write_prot = 0; 3416 + sdkp->cache_override = 0; 3417 + sdkp->WCE = 0; 3418 + sdkp->RCD = 0; 3419 + sdkp->ATO = 0; 3420 + sdkp->first_scan = 1; 3421 + sdkp->max_medium_access_timeouts = SD_MAX_MEDIUM_TIMEOUTS; 3422 + 3423 + sd_revalidate_disk(gd); 3424 + 3425 + gd->flags = GENHD_FL_EXT_DEVT; 3426 + if (sdp->removable) { 3427 + gd->flags |= GENHD_FL_REMOVABLE; 3428 + gd->events |= DISK_EVENT_MEDIA_CHANGE; 3429 + gd->event_flags = DISK_EVENT_FLAG_POLL | DISK_EVENT_FLAG_UEVENT; 3430 + } 3431 + 3432 + blk_pm_runtime_init(sdp->request_queue, dev); 3433 + device_add_disk(dev, gd, NULL); 3434 + if (sdkp->capacity) 3435 + sd_dif_config_host(sdkp); 3436 + 3437 + sd_revalidate_disk(gd); 3438 + 3439 + if (sdkp->security) { 3440 + sdkp->opal_dev = init_opal_dev(sdp, &sd_sec_submit); 3441 + if (sdkp->opal_dev) 3442 + sd_printk(KERN_NOTICE, sdkp, "supports TCG Opal\n"); 3443 + } 3444 + 3445 + sd_printk(KERN_NOTICE, sdkp, "Attached SCSI %sdisk\n", 3446 + sdp->removable ? "removable " : ""); 3447 + scsi_autopm_put_device(sdp); 3347 3448 3348 3449 return 0; 3349 3450