Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

iommu/fsl: fix all kernel-doc warnings in fsl_pamu.c

Fix kernel-doc warnings as reported by the kernel test robot:

fsl_pamu.c:192: warning: expecting prototype for pamu_config_paace(). Prototype was for pamu_config_ppaace() instead
fsl_pamu.c:239: warning: Function parameter or member 'omi_index' not described in 'get_ome_index'
fsl_pamu.c:239: warning: Function parameter or member 'dev' not described in 'get_ome_index'
fsl_pamu.c:332: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Setup operation mapping and stash destinations for QMAN and QMAN portal.
fsl_pamu.c:361: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Setup the operation mapping table for various devices. This is a static

Fixes: 695093e38c3e ("iommu/fsl: Freescale PAMU driver and iommu implementation.")
Fixes: cd70d4659ff3 ("iommu/fsl: Various cleanups")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: lore.kernel.org/r/202302281151.B1WtZvSC-lkp@intel.com
Cc: Aditya Srivastava <yashsri421@gmail.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux.dev
Cc: Timur Tabi <timur@tabi.org>
Cc: Varun Sethi <Varun.Sethi@freescale.com>
Cc: Emil Medve <Emilian.Medve@Freescale.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Acked-by: Timur Tabi <timur@kernel.org>
Link: https://lore.kernel.org/r/20230308034504.9985-1-rdunlap@infradead.org
Signed-off-by: Joerg Roedel <jroedel@suse.de>

authored by

Randy Dunlap and committed by
Joerg Roedel
829a7955 e8d018dd

+5 -4
+5 -4
drivers/iommu/fsl_pamu.c
··· 178 178 } 179 179 180 180 /** 181 - * pamu_config_paace() - Sets up PPAACE entry for specified liodn 181 + * pamu_config_ppaace() - Sets up PPAACE entry for specified liodn 182 182 * 183 183 * @liodn: Logical IO device number 184 184 * @omi: Operation mapping index -- if ~omi == 0 then omi not defined ··· 232 232 /** 233 233 * get_ome_index() - Returns the index in the operation mapping table 234 234 * for device. 235 - * @*omi_index: pointer for storing the index value 235 + * @omi_index: pointer for storing the index value 236 + * @dev: target device 236 237 * 237 238 */ 238 239 void get_ome_index(u32 *omi_index, struct device *dev) ··· 329 328 #define QMAN_PORTAL_PAACE 2 330 329 #define BMAN_PAACE 3 331 330 332 - /** 331 + /* 333 332 * Setup operation mapping and stash destinations for QMAN and QMAN portal. 334 333 * Memory accesses to QMAN and BMAN private memory need not be coherent, so 335 334 * clear the PAACE entry coherency attribute for them. ··· 358 357 } 359 358 } 360 359 361 - /** 360 + /* 362 361 * Setup the operation mapping table for various devices. This is a static 363 362 * table where each table index corresponds to a particular device. PAMU uses 364 363 * this table to translate device transaction to appropriate corenet