[PATCH] sbp2: fix check of return value of hpsb_allocate_and_register_addrspace()

From: Stefan Richter <stefanr@s5r6.in-berlin.de>

I added a failure check in patch "sbp2: variable status FIFO address (fix
login timeout)" --- alas for a wrong error value. This is a bug since
Linux 2.6.16. Leads to NULL pointer dereference if the call failed, and
bogus failure handling if call succeeded.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: <stable@kernel.org>
Cc: Ben Collins <bcollins@debian.org>
Cc: Jody McIntyre <scjody@modernduck.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

authored by Stefan Richter and committed by Linus Torvalds 829a1985 948c51e6

+1 -1
+1 -1
drivers/ieee1394/sbp2.c
··· 845 845 &sbp2_highlevel, ud->ne->host, &sbp2_ops, 846 846 sizeof(struct sbp2_status_block), sizeof(quadlet_t), 847 847 0x010000000000ULL, CSR1212_ALL_SPACE_END); 848 - if (!scsi_id->status_fifo_addr) { 848 + if (scsi_id->status_fifo_addr == ~0ULL) { 849 849 SBP2_ERR("failed to allocate status FIFO address range"); 850 850 goto failed_alloc; 851 851 }