Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ipmi: increase KCS timeouts

We currently time out and retry KCS transactions after 1 second of waiting
for IBF or OBF. This appears to be too short for some hardware. The IPMI
spec says "All system software wait loops should include error timeouts.
For simplicity, such timeouts are not shown explicitly in the flow
diagrams. A five-second timeout or greater is recommended". Change the
timeout to five seconds to satisfy the slow hardware.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Matthew Garrett and committed by
Linus Torvalds
828dc9da b88e7693

+2 -2
+2 -2
drivers/char/ipmi/ipmi_kcs_sm.c
··· 118 118 #define MAX_KCS_WRITE_SIZE IPMI_MAX_MSG_LENGTH 119 119 120 120 /* Timeouts in microseconds. */ 121 - #define IBF_RETRY_TIMEOUT 1000000 122 - #define OBF_RETRY_TIMEOUT 1000000 121 + #define IBF_RETRY_TIMEOUT 5000000 122 + #define OBF_RETRY_TIMEOUT 5000000 123 123 #define MAX_ERROR_RETRIES 10 124 124 #define ERROR0_OBF_WAIT_JIFFIES (2*HZ) 125 125