Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memory: omap-gpmc: fix wait pin validation

This bug has been introduced after switching from -1 to UINT_MAX
for GPMC_WAITPIN_INVALID.

The bug leads to an error when the optional gpmc,wait-pin
dt-property is not used:

...
gpmc_cs_program_settings: invalid wait-pin (-1)
...

Signed-off-by: Benedikt Niedermayr <benedikt.niedermayr@siemens.com>
Fixes: 8dd7e4af5853 ("memory: omap-gpmc: fix coverity issue "Control flow issues"")
Acked-by: Roger Quadros <rogerq@kernel.org>
Tested-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20221209112828.581491-1-benedikt.niedermayr@siemens.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

authored by

Benedikt Niedermayr and committed by
Krzysztof Kozlowski
827e0920 1b929c02

+2 -1
+2 -1
drivers/memory/omap-gpmc.c
··· 1918 1918 } 1919 1919 } 1920 1920 1921 - if (p->wait_pin > gpmc_nr_waitpins) { 1921 + if (p->wait_pin != GPMC_WAITPIN_INVALID && 1922 + p->wait_pin > gpmc_nr_waitpins) { 1922 1923 pr_err("%s: invalid wait-pin (%d)\n", __func__, p->wait_pin); 1923 1924 return -EINVAL; 1924 1925 }