Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

kunit: Add printf attribute to fail_current_test_impl

Add the gnu_printf (__printf()) attribute to the
kunit_fail_current_test() implementation in
__kunit_fail_current_test_impl(). While it's not actually useful here,
as this function is never called directly, it nevertheless was
triggering -Wsuggest-attribute=format warnings, so we should add it to
reduce the noise.

Fixes: cc3ed2fe5c93 ("kunit: Add "hooks" to call into KUnit when it's built as a module")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: David Gow <davidgow@google.com>
Reviewed-by: Rae Moar <rmoar@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

authored by

David Gow and committed by
Shuah Khan
82649c7c 789538c6

+4 -2
+3 -1
lib/kunit/hooks-impl.h
··· 15 15 #include <kunit/test-bug.h> 16 16 17 17 /* List of declarations. */ 18 - void __kunit_fail_current_test_impl(const char *file, int line, const char *fmt, ...); 18 + void __printf(3, 4) __kunit_fail_current_test_impl(const char *file, 19 + int line, 20 + const char *fmt, ...); 19 21 void *__kunit_get_static_stub_address_impl(struct kunit *test, void *real_fn_addr); 20 22 21 23 /* Code to set all of the function pointers. */
+1 -1
lib/kunit/test.c
··· 24 24 /* 25 25 * Hook to fail the current test and print an error message to the log. 26 26 */ 27 - void __kunit_fail_current_test_impl(const char *file, int line, const char *fmt, ...) 27 + void __printf(3, 4) __kunit_fail_current_test_impl(const char *file, int line, const char *fmt, ...) 28 28 { 29 29 va_list args; 30 30 int len;