Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ucsi_ccg: Check DEV_INT bit only when starting CCG4

CCGx clears Bit 0:Device Interrupt in the INTR_REG
if CCGx is reset successfully. However, there might
be a chance that other bits in INTR_REG are not
cleared due to internal data queued in PPM. This case
misleads the driver that CCGx reset failed.

The commit checks bit 0 in INTR_REG and ignores other
bits. The ucsi driver would reset PPM later.

Fixes: 247c554a14aa ("usb: typec: ucsi: add support for Cypress CCGx")
Cc: stable@vger.kernel.org
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Sing-Han Chen <singhanc@nvidia.com>
Signed-off-by: Wayne Chang <waynec@nvidia.com>
Link: https://lore.kernel.org/r/20220112094143.628610-1-waynec@nvidia.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Sing-Han Chen and committed by
Greg Kroah-Hartman
82591149 26fbe977

+1 -1
+1 -1
drivers/usb/typec/ucsi/ucsi_ccg.c
··· 325 325 if (status < 0) 326 326 return status; 327 327 328 - if (!data) 328 + if (!(data & DEV_INT)) 329 329 return 0; 330 330 331 331 status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data));