Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

platform/chrome: cros_ec_debugfs: Use cros_ec_cmd_xfer_status helper

This patch makes use of cros_ec_cmd_xfer_status() instead of
cros_ec_cmd_xfer() so we can remove some redundant code.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

+8 -22
+8 -22
drivers/platform/chrome/cros_ec_debugfs.c
··· 72 72 int buf_space; 73 73 int ret; 74 74 75 - ret = cros_ec_cmd_xfer(ec->ec_dev, &snapshot_msg); 76 - if (ret < 0) { 77 - dev_err(ec->dev, "EC communication failed\n"); 75 + ret = cros_ec_cmd_xfer_status(ec->ec_dev, &snapshot_msg); 76 + if (ret < 0) 78 77 goto resched; 79 - } 80 - if (snapshot_msg.result != EC_RES_SUCCESS) { 81 - dev_err(ec->dev, "EC failed to snapshot the console log\n"); 82 - goto resched; 83 - } 84 78 85 79 /* Loop until we have read everything, or there's an error. */ 86 80 mutex_lock(&debug_info->log_mutex); ··· 89 95 90 96 memset(read_params, '\0', sizeof(*read_params)); 91 97 read_params->subcmd = CONSOLE_READ_RECENT; 92 - ret = cros_ec_cmd_xfer(ec->ec_dev, debug_info->read_msg); 93 - if (ret < 0) { 94 - dev_err(ec->dev, "EC communication failed\n"); 98 + ret = cros_ec_cmd_xfer_status(ec->ec_dev, 99 + debug_info->read_msg); 100 + if (ret < 0) 95 101 break; 96 - } 97 - if (debug_info->read_msg->result != EC_RES_SUCCESS) { 98 - dev_err(ec->dev, 99 - "EC failed to read the console log\n"); 100 - break; 101 - } 102 102 103 103 /* If the buffer is empty, we're done here. */ 104 104 if (ret == 0 || ec_buffer[0] == '\0') ··· 278 290 params->cmd = EC_CMD_CONSOLE_READ; 279 291 response = (struct ec_response_get_cmd_versions *)msg->data; 280 292 281 - ret = cros_ec_cmd_xfer(ec->ec_dev, msg) >= 0 && 282 - msg->result == EC_RES_SUCCESS && 283 - (response->version_mask & EC_VER_MASK(1)); 293 + ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg) >= 0 && 294 + response->version_mask & EC_VER_MASK(1); 284 295 285 296 kfree(msg); 286 297 ··· 359 372 msg->command = EC_CMD_GET_PANIC_INFO; 360 373 msg->insize = insize; 361 374 362 - ret = cros_ec_cmd_xfer(ec_dev, msg); 375 + ret = cros_ec_cmd_xfer_status(ec_dev, msg); 363 376 if (ret < 0) { 364 - dev_warn(debug_info->ec->dev, "Cannot read panicinfo.\n"); 365 377 ret = 0; 366 378 goto free; 367 379 }