Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: logitech-hidpp: initialize level variable

Static analysis reports this representative problem

hid-logitech-hidpp.c:1356:23: warning: Assigned value is
garbage or undefined
hidpp->battery.level = level;
^ ~~~~~

In some cases, 'level' is never set in hidpp20_battery_map_status_voltage()
Since level is not available on all hw, initialize level to unknown.

Fixes: be281368f297 ("hid-logitech-hidpp: read battery voltage from newer devices")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

authored by

Tom Rix and committed by
Jiri Kosina
81c8bf91 31a4cf1d

+1
+1
drivers/hid/hid-logitech-hidpp.c
··· 1263 1263 int status; 1264 1264 1265 1265 long flags = (long) data[2]; 1266 + *level = POWER_SUPPLY_CAPACITY_LEVEL_UNKNOWN; 1266 1267 1267 1268 if (flags & 0x80) 1268 1269 switch (flags & 0x07) {