Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[PATCH] PCI: make it easier to see that set_msi_affinity() is used

I missed this usage in drivers/pci/msi.h:

#ifdef CONFIG_SMP
#define set_msi_irq_affinity set_msi_affinity
#else
#define set_msi_irq_affinity NULL
#endif

set_msi_affinity() is declared and exclusively used in msi.c.
Here's a better way so (hopefully) history doesn't repeat itself.

Signed-off-by: Grant Grundler <iod00d@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Grant Grundler and committed by
Greg Kroah-Hartman
8169b5d2 f8d65713

+5 -9
+5 -3
drivers/pci/msi.c
··· 137 137 break; 138 138 } 139 139 } 140 + #else 141 + #define set_msi_affinity NULL 140 142 #endif /* CONFIG_SMP */ 141 143 142 144 static void mask_MSI_irq(unsigned int vector) ··· 216 214 .disable = mask_MSI_irq, 217 215 .ack = mask_MSI_irq, 218 216 .end = end_msi_irq_w_maskbit, 219 - .set_affinity = set_msi_irq_affinity 217 + .set_affinity = set_msi_affinity 220 218 }; 221 219 222 220 /* ··· 232 230 .disable = mask_MSI_irq, 233 231 .ack = mask_MSI_irq, 234 232 .end = end_msi_irq_w_maskbit, 235 - .set_affinity = set_msi_irq_affinity 233 + .set_affinity = set_msi_affinity 236 234 }; 237 235 238 236 /* ··· 248 246 .disable = do_nothing, 249 247 .ack = do_nothing, 250 248 .end = end_msi_irq_wo_maskbit, 251 - .set_affinity = set_msi_irq_affinity 249 + .set_affinity = set_msi_affinity 252 250 }; 253 251 254 252 static void msi_data_init(struct msg_data *msi_data,
-6
drivers/pci/msi.h
··· 22 22 extern void (*interrupt[NR_IRQS])(void); 23 23 extern int pci_vector_resources(int last, int nr_released); 24 24 25 - #ifdef CONFIG_SMP 26 - #define set_msi_irq_affinity set_msi_affinity 27 - #else 28 - #define set_msi_irq_affinity NULL 29 - #endif 30 - 31 25 /* 32 26 * MSI-X Address Register 33 27 */