Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dma-debug: fix return value of __setup handlers

When valid kernel command line parameters
dma_debug=off dma_debug_entries=100
are used, they are reported as Unknown parameters and added to init's
environment strings, polluting it.

Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc5
dma_debug=off dma_debug_entries=100", will be passed to user space.

and

Run /sbin/init as init process
with arguments:
/sbin/init
with environment:
HOME=/
TERM=linux
BOOT_IMAGE=/boot/bzImage-517rc5
dma_debug=off
dma_debug_entries=100

Return 1 from these __setup handlers to indicate that the command line
option has been handled.

Fixes: 59d3daafa1726 ("dma-debug: add kernel command line parameters")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: iommu@lists.linux-foundation.org
Cc: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

authored by

Randy Dunlap and committed by
Christoph Hellwig
80e43909 f5ff79fd

+2 -2
+2 -2
kernel/dma/debug.c
··· 927 927 global_disable = true; 928 928 } 929 929 930 - return 0; 930 + return 1; 931 931 } 932 932 933 933 static __init int dma_debug_entries_cmdline(char *str) ··· 936 936 return -EINVAL; 937 937 if (!get_option(&str, &nr_prealloc_entries)) 938 938 nr_prealloc_entries = PREALLOC_DMA_DEBUG_ENTRIES; 939 - return 0; 939 + return 1; 940 940 } 941 941 942 942 __setup("dma_debug=", dma_debug_cmdline);