Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: scsi_dh_alua: Fix signedness bug in alua_rtpg()

The "retval" variable needs to be signed for the error handling to work.

Link: https://lore.kernel.org/r/YLjMEAFNxOas1mIp@mwanda
Fixes: 7e26e3ea0287 ("scsi: scsi_dh_alua: Check for negative result value")
Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Dan Carpenter and committed by
Martin K. Petersen
80927822 8b1afb7a

+2 -1
+2 -1
drivers/scsi/device_handler/scsi_dh_alua.c
··· 518 518 int len, k, off, bufflen = ALUA_RTPG_SIZE; 519 519 int group_id_old, state_old, pref_old, valid_states_old; 520 520 unsigned char *desc, *buff; 521 - unsigned err, retval; 521 + unsigned err; 522 + int retval; 522 523 unsigned int tpg_desc_tbl_off; 523 524 unsigned char orig_transition_tmo; 524 525 unsigned long flags;