Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/test: drm_exec: fix memory leak on object prepare

drm_exec_prepare_obj() and drm_exec_prepare_array() both reserve
dma-fence slots and hence a dma_resv_list without ever freeing it.

Make sure to call drm_gem_private_object_fini() for each GEM object
passed to drm_exec_prepare_obj()/drm_exec_prepare_array() throughout the
test to fix this up.

While at it, remove some trailing empty lines.

Fixes: 9710631cc8f3 ("drm: add drm_exec selftests v4")
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230809225034.8803-1-dakr@redhat.com
Signed-off-by: Christian König <christian.koenig@amd.com>

authored by

Danilo Krummrich and committed by
Christian König
806fd6d0 d01cb045

+5 -2
+5 -2
drivers/gpu/drm/tests/drm_exec_test.c
··· 125 125 drm_exec_fini(&exec); 126 126 } 127 127 128 - 129 - 130 128 static void test_prepare(struct kunit *test) 131 129 { 132 130 struct drm_exec_priv *priv = test->priv; ··· 143 145 break; 144 146 } 145 147 drm_exec_fini(&exec); 148 + 149 + drm_gem_private_object_fini(&gobj); 146 150 } 147 151 148 152 static void test_prepare_array(struct kunit *test) ··· 165 165 1); 166 166 KUNIT_EXPECT_EQ(test, ret, 0); 167 167 drm_exec_fini(&exec); 168 + 169 + drm_gem_private_object_fini(&gobj1); 170 + drm_gem_private_object_fini(&gobj2); 168 171 } 169 172 170 173 static void test_multiple_loops(struct kunit *test)