Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sctp: Reduce switch/case indent

Make the case labels the same indent as the switch.

git diff -w shows useless break;s removed after returns
and a comment added to an unnecessary default: break;
because of a dubious gcc warning.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Joe Perches and committed by
David S. Miller
7fd71b1e c4855389

+31 -30
+26 -25
net/sctp/sm_statefuns.c
··· 4008 4008 auth_hdr = (struct sctp_authhdr *)chunk->skb->data; 4009 4009 error = sctp_sf_authenticate(ep, asoc, type, chunk); 4010 4010 switch (error) { 4011 - case SCTP_IERROR_AUTH_BAD_HMAC: 4012 - /* Generate the ERROR chunk and discard the rest 4013 - * of the packet 4014 - */ 4015 - err_chunk = sctp_make_op_error(asoc, chunk, 4016 - SCTP_ERROR_UNSUP_HMAC, 4017 - &auth_hdr->hmac_id, 4018 - sizeof(__u16), 0); 4019 - if (err_chunk) { 4020 - sctp_add_cmd_sf(commands, SCTP_CMD_REPLY, 4021 - SCTP_CHUNK(err_chunk)); 4022 - } 4023 - /* Fall Through */ 4024 - case SCTP_IERROR_AUTH_BAD_KEYID: 4025 - case SCTP_IERROR_BAD_SIG: 4026 - return sctp_sf_pdiscard(ep, asoc, type, arg, commands); 4027 - break; 4028 - case SCTP_IERROR_PROTO_VIOLATION: 4029 - return sctp_sf_violation_chunklen(ep, asoc, type, arg, 4030 - commands); 4031 - break; 4032 - case SCTP_IERROR_NOMEM: 4033 - return SCTP_DISPOSITION_NOMEM; 4034 - default: 4035 - break; 4011 + case SCTP_IERROR_AUTH_BAD_HMAC: 4012 + /* Generate the ERROR chunk and discard the rest 4013 + * of the packet 4014 + */ 4015 + err_chunk = sctp_make_op_error(asoc, chunk, 4016 + SCTP_ERROR_UNSUP_HMAC, 4017 + &auth_hdr->hmac_id, 4018 + sizeof(__u16), 0); 4019 + if (err_chunk) { 4020 + sctp_add_cmd_sf(commands, SCTP_CMD_REPLY, 4021 + SCTP_CHUNK(err_chunk)); 4022 + } 4023 + /* Fall Through */ 4024 + case SCTP_IERROR_AUTH_BAD_KEYID: 4025 + case SCTP_IERROR_BAD_SIG: 4026 + return sctp_sf_pdiscard(ep, asoc, type, arg, commands); 4027 + 4028 + case SCTP_IERROR_PROTO_VIOLATION: 4029 + return sctp_sf_violation_chunklen(ep, asoc, type, arg, 4030 + commands); 4031 + 4032 + case SCTP_IERROR_NOMEM: 4033 + return SCTP_DISPOSITION_NOMEM; 4034 + 4035 + default: /* Prevent gcc warnings */ 4036 + break; 4036 4037 } 4037 4038 4038 4039 if (asoc->active_key_id != ntohs(auth_hdr->shkey_id)) {
+5 -5
net/sctp/socket.c
··· 3257 3257 return -EFAULT; 3258 3258 3259 3259 switch (val.sauth_chunk) { 3260 - case SCTP_CID_INIT: 3261 - case SCTP_CID_INIT_ACK: 3262 - case SCTP_CID_SHUTDOWN_COMPLETE: 3263 - case SCTP_CID_AUTH: 3264 - return -EINVAL; 3260 + case SCTP_CID_INIT: 3261 + case SCTP_CID_INIT_ACK: 3262 + case SCTP_CID_SHUTDOWN_COMPLETE: 3263 + case SCTP_CID_AUTH: 3264 + return -EINVAL; 3265 3265 } 3266 3266 3267 3267 /* add this chunk id to the endpoint */