Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

tools lib traceevent: Fix and cleanup kvm_nested_vmexit tracepoints

Fix several issues of kvm_nested_vmexit[_inject]: field width aren't
supported with pevent_print, rip was printed twice/incorrectly, SVM ISA
was hard-coded, we don't use ':' to separate field names.

Link: http://lkml.kernel.org/r/8e6c02b22ea8136c139a91c69d6cc73b8c5c184b.1388855989.git.jan.kiszka@web.de

Acked-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>

authored by

Jan Kiszka and committed by
Jiri Olsa
7f6e3635 ea092aeb

+6 -12
+6 -12
tools/lib/traceevent/plugin_kvm.c
··· 330 330 static int kvm_nested_vmexit_inject_handler(struct trace_seq *s, struct pevent_record *record, 331 331 struct event_format *event, void *context) 332 332 { 333 - unsigned long long val; 334 - 335 - pevent_print_num_field(s, " rip %0x016llx", event, "rip", record, 1); 336 - 337 - if (pevent_get_field_val(s, event, "exit_code", record, &val, 1) < 0) 333 + if (print_exit_reason(s, record, event, "exit_code") < 0) 338 334 return -1; 339 335 340 - trace_seq_printf(s, "reason %s", find_exit_reason(2, val)); 341 - 342 - pevent_print_num_field(s, " ext_inf1: %0x016llx", event, "exit_info1", record, 1); 343 - pevent_print_num_field(s, " ext_inf2: %0x016llx", event, "exit_info2", record, 1); 344 - pevent_print_num_field(s, " ext_int: %0x016llx", event, "exit_int_info", record, 1); 345 - pevent_print_num_field(s, " ext_int_err: %0x016llx", event, "exit_int_info_err", record, 1); 336 + pevent_print_num_field(s, " info1 %llx", event, "exit_info1", record, 1); 337 + pevent_print_num_field(s, " info2 %llx", event, "exit_info2", record, 1); 338 + pevent_print_num_field(s, " int_info %llx", event, "exit_int_info", record, 1); 339 + pevent_print_num_field(s, " int_info_err %llx", event, "exit_int_info_err", record, 1); 346 340 347 341 return 0; 348 342 } ··· 344 350 static int kvm_nested_vmexit_handler(struct trace_seq *s, struct pevent_record *record, 345 351 struct event_format *event, void *context) 346 352 { 347 - pevent_print_num_field(s, " rip %0x016llx", event, "rip", record, 1); 353 + pevent_print_num_field(s, "rip %lx ", event, "rip", record, 1); 348 354 349 355 return kvm_nested_vmexit_inject_handler(s, record, event, context); 350 356 }