Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: zynq: fix reference leak in zynq_gpio functions

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to putting operation will result in a
reference leak here.

A new function pm_runtime_resume_and_get is introduced in
[0] to keep usage counter balanced. So We fix the reference
leak by replacing it with new funtion.

[0] dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")

Fixes: c2df3de0d07e ("gpio: zynq: properly support runtime PM for GPIO used as interrupts")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

authored by

Qinglang Miao and committed by
Bartosz Golaszewski
7f57b295 6dbbf846

+2 -2
+2 -2
drivers/gpio/gpio-zynq.c
··· 574 574 struct gpio_chip *chip = irq_data_get_irq_chip_data(d); 575 575 int ret; 576 576 577 - ret = pm_runtime_get_sync(chip->parent); 577 + ret = pm_runtime_resume_and_get(chip->parent); 578 578 if (ret < 0) 579 579 return ret; 580 580 ··· 942 942 943 943 pm_runtime_set_active(&pdev->dev); 944 944 pm_runtime_enable(&pdev->dev); 945 - ret = pm_runtime_get_sync(&pdev->dev); 945 + ret = pm_runtime_resume_and_get(&pdev->dev); 946 946 if (ret < 0) 947 947 goto err_pm_dis; 948 948