Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: core: cfbcopyarea: fix sloppy typing

In cfb_copyarea(), the local variable bits_per_line is needlessly typed as
*unsigned long* -- which is a 32-bit type on the 32-bit arches and a 64-bit
type on the 64-bit arches; that variable's value is derived from the __u32
typed fb_fix_screeninfo::line_length field (multiplied by 8u) and a 32-bit
*unsigned int* type should still be enough to store the # of bits per line.

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Sergey Shtylyov and committed by
Helge Deller
7f33df94 1022e7e2

+1 -1
+1 -1
drivers/video/fbdev/core/cfbcopyarea.c
··· 382 382 { 383 383 u32 dx = area->dx, dy = area->dy, sx = area->sx, sy = area->sy; 384 384 u32 height = area->height, width = area->width; 385 - unsigned long const bits_per_line = p->fix.line_length*8u; 385 + unsigned int const bits_per_line = p->fix.line_length * 8u; 386 386 unsigned long __iomem *base = NULL; 387 387 int bits = BITS_PER_LONG, bytes = bits >> 3; 388 388 unsigned dst_idx = 0, src_idx = 0, rev_copy = 0;