Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARC: Fix __udelay calculation

Cast usecs to u64, to ensure that the (usecs * 4295 * HZ)
multiplication is 64 bit.

Initially, the (usecs * 4295 * HZ) part was done as a 32 bit
multiplication, with the result casted to 64 bit. This led to some bits
falling off, causing a "DMA initialization error" in the stmmac Ethernet
driver, due to a premature timeout.

Signed-off-by: Mischa Jonker <mjonker@synopsys.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>

authored by

Mischa Jonker and committed by
Vineet Gupta
7efd0da2 8508d565

+2 -3
+2 -3
arch/arc/include/asm/delay.h
··· 53 53 { 54 54 unsigned long loops; 55 55 56 - /* (long long) cast ensures 64 bit MPY - real or emulated 56 + /* (u64) cast ensures 64 bit MPY - real or emulated 57 57 * HZ * 4295 is pre-evaluated by gcc - hence only 2 mpy ops 58 58 */ 59 - loops = ((long long)(usecs * 4295 * HZ) * 60 - (long long)(loops_per_jiffy)) >> 32; 59 + loops = ((u64) usecs * 4295 * HZ * loops_per_jiffy) >> 32; 61 60 62 61 __delay(loops); 63 62 }