Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: axp288_fuel_gauge: Store struct device pointer in axp288_fg_info

Directly store the struct device pointer in axp288_fg_info, rather then
storing a pointer to the struct platform_device there and then using
"&info->pdev->dev" everywhere.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Hans de Goede and committed by
Sebastian Reichel
7eef3e66 f17bda7f

+24 -35
+24 -35
drivers/power/supply/axp288_fuel_gauge.c
··· 102 102 }; 103 103 104 104 struct axp288_fg_info { 105 - struct platform_device *pdev; 105 + struct device *dev; 106 106 struct regmap *regmap; 107 107 struct regmap_irq_chip_data *regmap_irqc; 108 108 int irq[AXP288_FG_INTR_NUM]; ··· 136 136 137 137 ret = regmap_read(info->regmap, reg, &val); 138 138 if (ret < 0) { 139 - dev_err(&info->pdev->dev, "Error reading reg 0x%02x err: %d\n", reg, ret); 139 + dev_err(info->dev, "Error reading reg 0x%02x err: %d\n", reg, ret); 140 140 return ret; 141 141 } 142 142 ··· 150 150 ret = regmap_write(info->regmap, reg, (unsigned int)val); 151 151 152 152 if (ret < 0) 153 - dev_err(&info->pdev->dev, "Error writing reg 0x%02x err: %d\n", reg, ret); 153 + dev_err(info->dev, "Error writing reg 0x%02x err: %d\n", reg, ret); 154 154 155 155 return ret; 156 156 } ··· 162 162 163 163 ret = regmap_bulk_read(info->regmap, reg, buf, 2); 164 164 if (ret < 0) { 165 - dev_err(&info->pdev->dev, "Error reading reg 0x%02x err: %d\n", 166 - reg, ret); 165 + dev_err(info->dev, "Error reading reg 0x%02x err: %d\n", reg, ret); 167 166 return ret; 168 167 } 169 168 170 169 ret = get_unaligned_be16(buf); 171 170 if (!(ret & FG_15BIT_WORD_VALID)) { 172 - dev_err(&info->pdev->dev, "Error reg 0x%02x contents not valid\n", 173 - reg); 171 + dev_err(info->dev, "Error reg 0x%02x contents not valid\n", reg); 174 172 return -ENXIO; 175 173 } 176 174 ··· 182 184 183 185 ret = regmap_bulk_read(info->regmap, reg, buf, 2); 184 186 if (ret < 0) { 185 - dev_err(&info->pdev->dev, "Error reading reg 0x%02x err: %d\n", 186 - reg, ret); 187 + dev_err(info->dev, "Error reading reg 0x%02x err: %d\n", reg, ret); 187 188 return ret; 188 189 } 189 190 ··· 196 199 197 200 pwr_stat = fuel_gauge_reg_readb(info, AXP20X_PWR_INPUT_STATUS); 198 201 if (pwr_stat < 0) { 199 - dev_err(&info->pdev->dev, 200 - "PWR STAT read failed:%d\n", pwr_stat); 202 + dev_err(info->dev, "PWR STAT read failed: %d\n", pwr_stat); 201 203 return; 202 204 } 203 205 ··· 206 210 207 211 fg_res = fuel_gauge_reg_readb(info, AXP20X_FG_RES); 208 212 if (fg_res < 0) { 209 - dev_err(&info->pdev->dev, "FG RES read failed: %d\n", fg_res); 213 + dev_err(info->dev, "FG RES read failed: %d\n", fg_res); 210 214 return; 211 215 } 212 216 if (!(fg_res & FG_REP_CAP_VALID)) ··· 228 232 229 233 ret = iio_read_channel_raw(info->iio_channel[BAT_D_CURR], &curr); 230 234 if (ret < 0) { 231 - dev_err(&info->pdev->dev, "FG get current failed: %d\n", ret); 235 + dev_err(info->dev, "FG get current failed: %d\n", ret); 232 236 return; 233 237 } 234 238 if (curr == 0) { ··· 351 355 goto fuel_gauge_read_err; 352 356 353 357 if (!(ret & FG_REP_CAP_VALID)) 354 - dev_err(&info->pdev->dev, 355 - "capacity measurement not valid\n"); 358 + dev_err(info->dev, "capacity measurement not valid\n"); 356 359 val->intval = (ret & FG_REP_CAP_VAL_MASK); 357 360 break; 358 361 case POWER_SUPPLY_PROP_CAPACITY_ALERT_MIN: ··· 450 455 } 451 456 452 457 if (i >= AXP288_FG_INTR_NUM) { 453 - dev_warn(&info->pdev->dev, "spurious interrupt!!\n"); 458 + dev_warn(info->dev, "spurious interrupt!!\n"); 454 459 return IRQ_NONE; 455 460 } 456 461 457 462 switch (i) { 458 463 case QWBTU_IRQ: 459 - dev_info(&info->pdev->dev, 460 - "Quit Battery under temperature in work mode IRQ (QWBTU)\n"); 464 + dev_info(info->dev, "Quit Battery under temperature in work mode IRQ (QWBTU)\n"); 461 465 break; 462 466 case WBTU_IRQ: 463 - dev_info(&info->pdev->dev, 464 - "Battery under temperature in work mode IRQ (WBTU)\n"); 467 + dev_info(info->dev, "Battery under temperature in work mode IRQ (WBTU)\n"); 465 468 break; 466 469 case QWBTO_IRQ: 467 - dev_info(&info->pdev->dev, 468 - "Quit Battery over temperature in work mode IRQ (QWBTO)\n"); 470 + dev_info(info->dev, "Quit Battery over temperature in work mode IRQ (QWBTO)\n"); 469 471 break; 470 472 case WBTO_IRQ: 471 - dev_info(&info->pdev->dev, 472 - "Battery over temperature in work mode IRQ (WBTO)\n"); 473 + dev_info(info->dev, "Battery over temperature in work mode IRQ (WBTO)\n"); 473 474 break; 474 475 case WL2_IRQ: 475 - dev_info(&info->pdev->dev, "Low Batt Warning(2) INTR\n"); 476 + dev_info(info->dev, "Low Batt Warning(2) INTR\n"); 476 477 break; 477 478 case WL1_IRQ: 478 - dev_info(&info->pdev->dev, "Low Batt Warning(1) INTR\n"); 479 + dev_info(info->dev, "Low Batt Warning(1) INTR\n"); 479 480 break; 480 481 default: 481 - dev_warn(&info->pdev->dev, "Spurious Interrupt!!!\n"); 482 + dev_warn(info->dev, "Spurious Interrupt!!!\n"); 482 483 } 483 484 484 485 power_supply_changed(info->bat); ··· 499 508 .external_power_changed = fuel_gauge_external_power_changed, 500 509 }; 501 510 502 - static void fuel_gauge_init_irq(struct axp288_fg_info *info) 511 + static void fuel_gauge_init_irq(struct axp288_fg_info *info, struct platform_device *pdev) 503 512 { 504 513 int ret, i, pirq; 505 514 506 515 for (i = 0; i < AXP288_FG_INTR_NUM; i++) { 507 - pirq = platform_get_irq(info->pdev, i); 516 + pirq = platform_get_irq(pdev, i); 508 517 info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq); 509 518 if (info->irq[i] < 0) { 510 - dev_warn(&info->pdev->dev, 511 - "regmap_irq get virq failed for IRQ %d: %d\n", 519 + dev_warn(info->dev, "regmap_irq get virq failed for IRQ %d: %d\n", 512 520 pirq, info->irq[i]); 513 521 info->irq[i] = -1; 514 522 goto intr_failed; ··· 516 526 NULL, fuel_gauge_thread_handler, 517 527 IRQF_ONESHOT, DEV_NAME, info); 518 528 if (ret) { 519 - dev_warn(&info->pdev->dev, 520 - "request irq failed for IRQ %d: %d\n", 529 + dev_warn(info->dev, "request irq failed for IRQ %d: %d\n", 521 530 pirq, info->irq[i]); 522 531 info->irq[i] = -1; 523 532 goto intr_failed; ··· 638 649 if (!info) 639 650 return -ENOMEM; 640 651 641 - info->pdev = pdev; 652 + info->dev = &pdev->dev; 642 653 info->regmap = axp20x->regmap; 643 654 info->regmap_irqc = axp20x->regmap_irqc; 644 655 info->status = POWER_SUPPLY_STATUS_UNKNOWN; ··· 703 714 goto out_free_iio_chan; 704 715 } 705 716 706 - fuel_gauge_init_irq(info); 717 + fuel_gauge_init_irq(info, pdev); 707 718 708 719 return 0; 709 720