Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: cavium-thunderx: Add of_node_put() when breaking out of loop

In thunder_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.

Fixes: 166bac38c3c5 ("mmc: cavium: Add MMC PCI driver for ThunderX SOCs")
Signed-off-by: Liang He <windhl@126.com>
Acked-by: Robert Richter <rric@kernel.org>
Link: https://lore.kernel.org/r/20220719095216.1241601-2-windhl@126.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Liang He and committed by
Ulf Hansson
7ee48079 19bbb49a

+3 -1
+3 -1
drivers/mmc/host/cavium-thunderx.c
··· 142 142 continue; 143 143 144 144 ret = cvm_mmc_of_slot_probe(&host->slot_pdev[i]->dev, host); 145 - if (ret) 145 + if (ret) { 146 + of_node_put(child_node); 146 147 goto error; 148 + } 147 149 } 148 150 i++; 149 151 }