Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net/handshake: Fix handshake_dup() ref counting

If get_unused_fd_flags() fails, we ended up calling fput(sock->file)
twice.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Suggested-by: Paolo Abeni <pabeni@redhat.com>
Fixes: 3b3009ea8abb ("net/handshake: Create a NETLINK service for handling handshake requests")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Chuck Lever and committed by
Jakub Kicinski
7ea9c1ec a095326e

+3 -2
+3 -2
net/handshake/netlink.c
··· 139 139 goto out_complete; 140 140 } 141 141 err = req->hr_proto->hp_accept(req, info, fd); 142 - if (err) 142 + if (err) { 143 + fput(sock->file); 143 144 goto out_complete; 145 + } 144 146 145 147 trace_handshake_cmd_accept(net, req, req->hr_sk, fd); 146 148 return 0; 147 149 148 150 out_complete: 149 151 handshake_complete(req, -EIO, NULL); 150 - fput(sock->file); 151 152 out_status: 152 153 trace_handshake_cmd_accept_err(net, req, NULL, err); 153 154 return err;