Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rndis_wlan: fix checking for default value

Thresholds uses -1 to indicate that default value should be used.
Since thresholds are unsigned sign checking makes no sense.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Andrzej Hajda and committed by
David S. Miller
7e724da6 e79dd09b

+1 -1
+1 -1
drivers/net/wireless/rndis_wlan.c
··· 1236 1236 1237 1237 netdev_dbg(usbdev->net, "%s(): %i\n", __func__, rts_threshold); 1238 1238 1239 - if (rts_threshold < 0 || rts_threshold > 2347) 1239 + if (rts_threshold == -1 || rts_threshold > 2347) 1240 1240 rts_threshold = 2347; 1241 1241 1242 1242 tmp = cpu_to_le32(rts_threshold);