Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] media: fix null pointer dereference in v4l_vb2q_enable_media_source()

Fix the null pointer dereference in v4l_vb2q_enable_media_source().
DVB only drivers don't have valid struct v4l2_fh pointer.

[ 548.443272] BUG: unable to handle kernel NULL pointer dereference
at 0000000000000010
[ 548.452036] IP: [<ffffffffc020ffc9>]
v4l_vb2q_enable_media_source+0x9/0x50 [videodev]
[ 548.460792] PGD b820e067 PUD bb3df067 PMD 0
[ 548.465582] Oops: 0000 [#1] SMP

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
Reported-by: Olli Salonen <olli.salonen@iki.fi>
Tested-by: Olli Salonen <olli.salonen@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Shuah Khan and committed by
Mauro Carvalho Chehab
7e53898a 1e89f584

+3 -1
+3 -1
drivers/media/v4l2-core/v4l2-mc.c
··· 240 240 { 241 241 struct v4l2_fh *fh = q->owner; 242 242 243 - return v4l_enable_media_source(fh->vdev); 243 + if (fh && fh->vdev) 244 + return v4l_enable_media_source(fh->vdev); 245 + return 0; 244 246 } 245 247 EXPORT_SYMBOL_GPL(v4l_vb2q_enable_media_source); 246 248