Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: omap2: remove potential format string leak

Since kobject_init_and_add takes a format string, make sure that the
passed in name cannot be accidentally parsed.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

authored by

Kees Cook and committed by
Tomi Valkeinen
7e46cd70 8dc0a565

+1 -1
+1 -1
drivers/video/fbdev/omap2/dss/display-sysfs.c
··· 324 324 325 325 for_each_dss_dev(dssdev) { 326 326 r = kobject_init_and_add(&dssdev->kobj, &display_ktype, 327 - &pdev->dev.kobj, dssdev->alias); 327 + &pdev->dev.kobj, "%s", dssdev->alias); 328 328 if (r) { 329 329 DSSERR("failed to create sysfs files\n"); 330 330 omap_dss_put_device(dssdev);