Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86: Make it so that __pa_symbol can only process kernel symbols on x86_64

I submitted an earlier patch that make __phys_addr an inline. This obviously
results in an increase in the code size. One step I can take to reduce that
is to make it so that the __pa_symbol call does a direct translation for
kernel addresses instead of covering all of virtual memory.

On my system this reduced the size for __pa_symbol from 5 instructions
totalling 30 bytes to 3 instructions totalling 16 bytes.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Link: http://lkml.kernel.org/r/20121116215356.8521.92472.stgit@ahduyck-cp1.jf.intel.com
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>

authored by

Alexander Duyck and committed by
H. Peter Anvin
7d74275d 0bdf525f

+17 -1
+2 -1
arch/x86/include/asm/page.h
··· 44 44 * case properly. Once all supported versions of gcc understand it, we can 45 45 * remove this Voodoo magic stuff. (i.e. once gcc3.x is deprecated) 46 46 */ 47 - #define __pa_symbol(x) __pa(__phys_reloc_hide((unsigned long)(x))) 47 + #define __pa_symbol(x) \ 48 + __phys_addr_symbol(__phys_reloc_hide((unsigned long)(x))) 48 49 49 50 #define __va(x) ((void *)((unsigned long)(x)+PAGE_OFFSET)) 50 51
+1
arch/x86/include/asm/page_32.h
··· 15 15 #else 16 16 #define __phys_addr(x) __phys_addr_nodebug(x) 17 17 #endif 18 + #define __phys_addr_symbol(x) __phys_addr(x) 18 19 #define __phys_reloc_hide(x) RELOC_HIDE((x), 0) 19 20 20 21 #ifdef CONFIG_FLATMEM
+3
arch/x86/include/asm/page_64.h
··· 21 21 22 22 #ifdef CONFIG_DEBUG_VIRTUAL 23 23 extern unsigned long __phys_addr(unsigned long); 24 + extern unsigned long __phys_addr_symbol(unsigned long); 24 25 #else 25 26 #define __phys_addr(x) __phys_addr_nodebug(x) 27 + #define __phys_addr_symbol(x) \ 28 + ((unsigned long)(x) - __START_KERNEL_map + phys_base) 26 29 #endif 27 30 28 31 #define __phys_reloc_hide(x) (x)
+11
arch/x86/mm/physaddr.c
··· 28 28 return x; 29 29 } 30 30 EXPORT_SYMBOL(__phys_addr); 31 + 32 + unsigned long __phys_addr_symbol(unsigned long x) 33 + { 34 + unsigned long y = x - __START_KERNEL_map; 35 + 36 + /* only check upper bounds since lower bounds will trigger carry */ 37 + VIRTUAL_BUG_ON(y >= KERNEL_IMAGE_SIZE); 38 + 39 + return y + phys_base; 40 + } 41 + EXPORT_SYMBOL(__phys_addr_symbol); 31 42 #endif 32 43 33 44 bool __virt_addr_valid(unsigned long x)