Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver

Fix an incorrect NULL check reported by kbot in the MSM DP driver

smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect()
error: we previously assumed 'hpd_priv->dp_cb' could be null
(see line 37)

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/1614971839-2686-2-git-send-email-abhinavk@codeaurora.org
Signed-off-by: Rob Clark <robdclark@chromium.org>

authored by

Abhinav Kumar and committed by
Rob Clark
7d649cfe 86bf2545

+2 -2
+2 -2
drivers/gpu/drm/msm/dp/dp_hpd.c
··· 34 34 35 35 dp_usbpd->hpd_high = hpd; 36 36 37 - if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure 38 - && !hpd_priv->dp_cb->disconnect) { 37 + if (!hpd_priv->dp_cb || !hpd_priv->dp_cb->configure 38 + || !hpd_priv->dp_cb->disconnect) { 39 39 pr_err("hpd dp_cb not initialized\n"); 40 40 return -EINVAL; 41 41 }