Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: openvswitch: Use 'skb_push_rcsum()' instead of hand coding it

'skb_push()'/'skb_postpush_rcsum()' can be replaced by an equivalent
'skb_push_rcsum()' which is less verbose.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Christophe JAILLET and committed by
David S. Miller
7d42e84e cd77ce93

+5 -8
+2 -4
net/openvswitch/conntrack.c
··· 809 809 810 810 err = nf_nat_packet(ct, ctinfo, hooknum, skb); 811 811 push: 812 - skb_push(skb, nh_off); 813 - skb_postpush_rcsum(skb, skb->data, nh_off); 812 + skb_push_rcsum(skb, nh_off); 814 813 815 814 return err; 816 815 } ··· 1321 1322 else 1322 1323 err = ovs_ct_lookup(net, key, info, skb); 1323 1324 1324 - skb_push(skb, nh_ofs); 1325 - skb_postpush_rcsum(skb, skb->data, nh_ofs); 1325 + skb_push_rcsum(skb, nh_ofs); 1326 1326 if (err) 1327 1327 kfree_skb(skb); 1328 1328 return err;
+3 -4
net/openvswitch/vport-netdev.c
··· 44 44 if (unlikely(!skb)) 45 45 return; 46 46 47 - if (skb->dev->type == ARPHRD_ETHER) { 48 - skb_push(skb, ETH_HLEN); 49 - skb_postpush_rcsum(skb, skb->data, ETH_HLEN); 50 - } 47 + if (skb->dev->type == ARPHRD_ETHER) 48 + skb_push_rcsum(skb, ETH_HLEN); 49 + 51 50 ovs_vport_receive(vport, skb, skb_tunnel_info(skb)); 52 51 return; 53 52 error: