Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

can: sja1000: clear interrupts on start

According to SJA1000 data sheet error-warning (EI) interrupt is not
cleared by setting the controller in to reset-mode.

Then if we have the following case:
- system is suspended (echo mem > /sys/power/state) and SJA1000 is left
in operating state
- A bus error condition occurs which activates EI interrupt, system is
still suspended which means EI interrupt will be not be handled nor
cleared.

If the above two events occur, on resume there is no way to return the
SJA1000 to operating state, except to cycle power to it.

By simply reading the IR register on start we will clear any previous
conditions that could be present.

Signed-off-by: Mirza Krak <mirza.krak@hostmobility.com>
Reported-by: Christian Magnusson <Christian.Magnusson@semcon.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

authored by

Mirza Krak and committed by
Marc Kleine-Budde
7cecd9ab 4c698046

+3
+3
drivers/net/can/sja1000/sja1000.c
··· 218 218 priv->write_reg(priv, SJA1000_RXERR, 0x0); 219 219 priv->read_reg(priv, SJA1000_ECC); 220 220 221 + /* clear interrupt flags */ 222 + priv->read_reg(priv, SJA1000_IR); 223 + 221 224 /* leave reset mode */ 222 225 set_normal_mode(dev); 223 226 }