Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

serial: 8250_lpss: Unconditionally set PCI master for Quark

MSI needs it as well.

Should have no practical impact, though, as DMA is always available on
the Quark. But given the few users of pci_alloc_irq_vectors so far, this
incorrect pattern may spread otherwise.

Fixes: 3f3a46951e02 ("serial: 8250_lpss: set PCI master only for private DMA")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Jan Kiszka and committed by
Greg Kroah-Hartman
7cd3e9db 2ed2b862

+2 -1
+2 -1
drivers/tty/serial/8250/8250_lpss.c
··· 183 183 if (ret) 184 184 return; 185 185 186 - pci_set_master(pdev); 187 186 pci_try_set_mwi(pdev); 188 187 189 188 /* Special DMA address for UART */ ··· 214 215 { 215 216 struct pci_dev *pdev = to_pci_dev(port->dev); 216 217 int ret; 218 + 219 + pci_set_master(pdev); 217 220 218 221 ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES); 219 222 if (ret < 0)