Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[ARM] omap: fix a load of "warning: symbol 'xxx' was not declared. Should it be static?"

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

authored by

Russell King and committed by
Russell King
7c8ad982 c0fc18c5

+16 -9
+1 -1
drivers/input/keyboard/omap-keypad.c
··· 62 62 unsigned int debounce; 63 63 }; 64 64 65 - DECLARE_TASKLET_DISABLED(kp_tasklet, omap_kp_tasklet, 0); 65 + static DECLARE_TASKLET_DISABLED(kp_tasklet, omap_kp_tasklet, 0); 66 66 67 67 static int *keymap; 68 68 static unsigned int *row_gpios;
+2 -2
drivers/mmc/host/omap.c
··· 172 172 struct omap_mmc_platform_data *pdata; 173 173 }; 174 174 175 - void mmc_omap_fclk_offdelay(struct mmc_omap_slot *slot) 175 + static void mmc_omap_fclk_offdelay(struct mmc_omap_slot *slot) 176 176 { 177 177 unsigned long tick_ns; 178 178 ··· 182 182 } 183 183 } 184 184 185 - void mmc_omap_fclk_enable(struct mmc_omap_host *host, unsigned int enable) 185 + static void mmc_omap_fclk_enable(struct mmc_omap_host *host, unsigned int enable) 186 186 { 187 187 unsigned long flags; 188 188
+2
drivers/video/omap/dispc.h
··· 40 40 extern int omap_dispc_request_irq(void (*callback)(void *data), void *data); 41 41 extern void omap_dispc_free_irq(void); 42 42 43 + extern const struct lcd_ctrl omap2_int_ctrl; 44 + 43 45 #endif
+2 -2
drivers/video/omap/lcd_h4.c
··· 47 47 return 0; 48 48 } 49 49 50 - struct lcd_panel h4_panel = { 50 + static struct lcd_panel h4_panel = { 51 51 .name = "h4", 52 52 .config = OMAP_LCDC_PANEL_TFT, 53 53 ··· 91 91 return 0; 92 92 } 93 93 94 - struct platform_driver h4_panel_driver = { 94 + static struct platform_driver h4_panel_driver = { 95 95 .probe = h4_panel_probe, 96 96 .remove = h4_panel_remove, 97 97 .suspend = h4_panel_suspend,
+2
drivers/video/omap/lcdc.c
··· 34 34 35 35 #include <asm/mach-types.h> 36 36 37 + #include "lcdc.h" 38 + 37 39 #define MODULE_NAME "lcdc" 38 40 39 41 #define OMAP_LCDC_BASE 0xfffec000
+2
drivers/video/omap/lcdc.h
··· 4 4 int omap_lcdc_set_dma_callback(void (*callback)(void *data), void *data); 5 5 void omap_lcdc_free_dma_callback(void); 6 6 7 + extern const struct lcd_ctrl omap1_int_ctrl; 8 + 7 9 #endif
+5 -4
drivers/video/omap/omapfb_main.c
··· 31 31 #include <mach/dma.h> 32 32 #include <mach/omapfb.h> 33 33 34 + #include "lcdc.h" 35 + #include "dispc.h" 36 + 34 37 #define MODULE_NAME "omapfb" 35 38 36 39 static unsigned int def_accel; 37 40 static unsigned long def_vram[OMAPFB_PLANE_NUM]; 38 - static int def_vram_cnt; 41 + static unsigned int def_vram_cnt; 39 42 static unsigned long def_vxres; 40 43 static unsigned long def_vyres; 41 44 static unsigned int def_rotate; ··· 87 84 * LCD panel 88 85 * --------------------------------------------------------------------------- 89 86 */ 90 - extern struct lcd_ctrl omap1_int_ctrl; 91 - extern struct lcd_ctrl omap2_int_ctrl; 92 87 extern struct lcd_ctrl hwa742_ctrl; 93 88 extern struct lcd_ctrl blizzard_ctrl; 94 89 95 - static struct lcd_ctrl *ctrls[] = { 90 + static const struct lcd_ctrl *ctrls[] = { 96 91 #ifdef CONFIG_ARCH_OMAP1 97 92 &omap1_int_ctrl, 98 93 #else