Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/elf/64: Clear more registers in elf_common_init()

Before we start calling execve in contexts that honor the full
pt_regs, we need to teach it to initialize all registers.

Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/65a38a9edee61a1158cfd230800c61dbd963dac5.1444091584.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by

Andy Lutomirski and committed by
Ingo Molnar
7bcdea4d 29c0ce95

+4 -4
+4 -4
arch/x86/include/asm/elf.h
··· 171 171 static inline void elf_common_init(struct thread_struct *t, 172 172 struct pt_regs *regs, const u16 ds) 173 173 { 174 - /* Commented-out registers are cleared in stub_execve */ 175 - /*regs->ax = regs->bx =*/ regs->cx = regs->dx = 0; 176 - regs->si = regs->di /*= regs->bp*/ = 0; 174 + /* ax gets execve's return value. */ 175 + /*regs->ax = */ regs->bx = regs->cx = regs->dx = 0; 176 + regs->si = regs->di = regs->bp = 0; 177 177 regs->r8 = regs->r9 = regs->r10 = regs->r11 = 0; 178 - /*regs->r12 = regs->r13 = regs->r14 = regs->r15 = 0;*/ 178 + regs->r12 = regs->r13 = regs->r14 = regs->r15 = 0; 179 179 t->fs = t->gs = 0; 180 180 t->fsindex = t->gsindex = 0; 181 181 t->ds = t->es = ds;