Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/lima: Reduce number of PTR_ERR() calls

Store the PTR_ERR() result in local variable in clock init error path.
This makes the code consistent with similar section in regulator init
code.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190621162117.22533-3-krzk@kernel.org

authored by

Krzysztof Kozlowski and committed by
Qiang Yu
7b4e467d 34e88f9e

+6 -4
+6 -4
drivers/gpu/drm/lima/lima_device.c
··· 83 83 84 84 dev->clk_bus = devm_clk_get(dev->dev, "bus"); 85 85 if (IS_ERR(dev->clk_bus)) { 86 - dev_err(dev->dev, "get bus clk failed %ld\n", PTR_ERR(dev->clk_bus)); 87 - return PTR_ERR(dev->clk_bus); 86 + err = PTR_ERR(dev->clk_bus); 87 + dev_err(dev->dev, "get bus clk failed %d\n", err); 88 + return err; 88 89 } 89 90 90 91 dev->clk_gpu = devm_clk_get(dev->dev, "core"); 91 92 if (IS_ERR(dev->clk_gpu)) { 92 - dev_err(dev->dev, "get core clk failed %ld\n", PTR_ERR(dev->clk_gpu)); 93 - return PTR_ERR(dev->clk_gpu); 93 + err = PTR_ERR(dev->clk_gpu); 94 + dev_err(dev->dev, "get core clk failed %d\n", err); 95 + return err; 94 96 } 95 97 96 98 err = clk_prepare_enable(dev->clk_bus);