Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: b44: fix error return code in b44_init_one()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 39a6f4bce6b4 ("b44: replace the ssb_dma API with the generic DMA API")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/1605582131-36735-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Zhang Changzhong and committed by
Jakub Kicinski
7b027c24 cb47d16e

+2 -1
+2 -1
drivers/net/ethernet/broadcom/b44.c
··· 2383 2383 goto err_out_free_dev; 2384 2384 } 2385 2385 2386 - if (dma_set_mask_and_coherent(sdev->dma_dev, DMA_BIT_MASK(30))) { 2386 + err = dma_set_mask_and_coherent(sdev->dma_dev, DMA_BIT_MASK(30)); 2387 + if (err) { 2387 2388 dev_err(sdev->dev, 2388 2389 "Required 30BIT DMA mask unsupported by the system\n"); 2389 2390 goto err_out_powerdown;