Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/ftrace: Ignore weak functions

Extend commit b39181f7c6907d ("ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to
avoid adding weak function") to ppc32 and ppc64 -mprofile-kernel by
defining FTRACE_MCOUNT_MAX_OFFSET.

For ppc64 -mprofile-kernel ABI, we can have two instructions at function
entry for TOC setup followed by 'mflr r0' and 'bl _mcount'. So, the
mcount location is at most the 4th instruction in a function. For ppc32,
mcount location is always the 3rd instruction in a function, preceded by
'mflr r0' and 'stw r0,4(r1)'.

With this patch, and with ppc64le_guest_defconfig and some ftrace/bpf
config items enabled:
# grep __ftrace_invalid_address available_filter_functions | wc -l
79

Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220809105425.424045-1-naveen.n.rao@linux.vnet.ibm.com

authored by

Naveen N. Rao and committed by
Michael Ellerman
7af82ff9 14b5d59a

+7
+7
arch/powerpc/include/asm/ftrace.h
··· 10 10 11 11 #define HAVE_FUNCTION_GRAPH_RET_ADDR_PTR 12 12 13 + /* Ignore unused weak functions which will have larger offsets */ 14 + #ifdef CONFIG_MPROFILE_KERNEL 15 + #define FTRACE_MCOUNT_MAX_OFFSET 12 16 + #elif defined(CONFIG_PPC32) 17 + #define FTRACE_MCOUNT_MAX_OFFSET 8 18 + #endif 19 + 13 20 #ifndef __ASSEMBLY__ 14 21 extern void _mcount(void); 15 22