Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (smsc47m1) Rename global platform device variable

pdev is a bad name for a global variable. Still more as the driver has
functions where pdev is a local variable. Rename it to smsc47m1_pdev.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/68a959b56da7f9452557d08c72249182364b0dd0.1701957841.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Uwe Kleine-König and committed by
Guenter Roeck
7ae587eb 58107695

+8 -8
+8 -8
drivers/hwmon/smsc47m1.c
··· 33 33 module_param(force_id, ushort, 0); 34 34 MODULE_PARM_DESC(force_id, "Override the detected device ID"); 35 35 36 - static struct platform_device *pdev; 36 + static struct platform_device *smsc47m1_pdev; 37 37 38 38 #define DRVNAME "smsc47m1" 39 39 enum chips { smsc47m1, smsc47m2 }; ··· 884 884 if (err) 885 885 return err; 886 886 887 - pdev = platform_device_register_full(&pdevinfo); 888 - if (IS_ERR(pdev)) { 887 + smsc47m1_pdev = platform_device_register_full(&pdevinfo); 888 + if (IS_ERR(smsc47m1_pdev)) { 889 889 pr_err("Device allocation failed\n"); 890 - return PTR_ERR(pdev); 890 + return PTR_ERR(smsc47m1_pdev); 891 891 } 892 892 893 893 return 0; ··· 904 904 return err; 905 905 address = err; 906 906 907 - /* Sets global pdev as a side effect */ 907 + /* Sets global smsc47m1_pdev as a side effect */ 908 908 err = smsc47m1_device_add(address, &sio_data); 909 909 if (err) 910 910 return err; ··· 916 916 return 0; 917 917 918 918 exit_device: 919 - platform_device_unregister(pdev); 919 + platform_device_unregister(smsc47m1_pdev); 920 920 smsc47m1_restore(&sio_data); 921 921 return err; 922 922 } ··· 924 924 static void __exit sm_smsc47m1_exit(void) 925 925 { 926 926 platform_driver_unregister(&smsc47m1_driver); 927 - smsc47m1_restore(dev_get_platdata(&pdev->dev)); 928 - platform_device_unregister(pdev); 927 + smsc47m1_restore(dev_get_platdata(&smsc47m1_pdev->dev)); 928 + platform_device_unregister(smsc47m1_pdev); 929 929 } 930 930 931 931 MODULE_AUTHOR("Mark D. Studebaker <mdsxyz123@yahoo.com>");