Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mtd: spi-nor: hisi-sfc: Add of_node_put() before break

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop, there
is no put, thus causing a memory leak. Hence add an of_node_put before
the break.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

authored by

Nishka Dasgupta and committed by
Tudor Ambarus
7ae2227b 6597f0b0

+1
+1
drivers/mtd/spi-nor/hisi-sfc.c
··· 401 401 402 402 if (host->num_chip == HIFMC_MAX_CHIP_NUM) { 403 403 dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n"); 404 + of_node_put(np); 404 405 break; 405 406 } 406 407 }