Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mmc: sdio: improve mmc_io_rw_extended

Improve mmc_io_rw_extended a little:
- using DIV_ROUND_UP achieves the same but is better readable
- simplify code by using sg_set_buf
- simplify one statement by using -= operator

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

authored by

Heiner Kallweit and committed by
Ulf Hansson
7aceaf56 474e25e1

+4 -5
+4 -5
drivers/mmc/core/sdio_ops.c
··· 152 152 data.flags = write ? MMC_DATA_WRITE : MMC_DATA_READ; 153 153 154 154 left_size = data.blksz * data.blocks; 155 - nents = (left_size - 1) / seg_size + 1; 155 + nents = DIV_ROUND_UP(left_size, seg_size); 156 156 if (nents > 1) { 157 157 if (sg_alloc_table(&sgtable, nents, GFP_KERNEL)) 158 158 return -ENOMEM; ··· 161 161 data.sg_len = nents; 162 162 163 163 for_each_sg(data.sg, sg_ptr, data.sg_len, i) { 164 - sg_set_page(sg_ptr, virt_to_page(buf + (i * seg_size)), 165 - min(seg_size, left_size), 166 - offset_in_page(buf + (i * seg_size))); 167 - left_size = left_size - seg_size; 164 + sg_set_buf(sg_ptr, buf + i * seg_size, 165 + min(seg_size, left_size)); 166 + left_size -= seg_size; 168 167 } 169 168 } else { 170 169 data.sg = &sg;