Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/i915: dev_priv cleanup in i915_gem_stolen.c

And a little bit of cascaded function prototype changes.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

+8 -10
+1 -1
drivers/gpu/drm/i915/i915_drv.h
··· 3279 3279 u64 end); 3280 3280 void i915_gem_stolen_remove_node(struct drm_i915_private *dev_priv, 3281 3281 struct drm_mm_node *node); 3282 - int i915_gem_init_stolen(struct drm_device *dev); 3282 + int i915_gem_init_stolen(struct drm_i915_private *dev_priv); 3283 3283 void i915_gem_cleanup_stolen(struct drm_device *dev); 3284 3284 struct drm_i915_gem_object * 3285 3285 i915_gem_object_create_stolen(struct drm_device *dev, u32 size);
+1 -1
drivers/gpu/drm/i915/i915_gem_gtt.c
··· 3252 3252 * Initialise stolen early so that we may reserve preallocated 3253 3253 * objects for the BIOS to KMS transition. 3254 3254 */ 3255 - ret = i915_gem_init_stolen(&dev_priv->drm); 3255 + ret = i915_gem_init_stolen(dev_priv); 3256 3256 if (ret) 3257 3257 goto out_gtt_cleanup; 3258 3258
+6 -8
drivers/gpu/drm/i915/i915_gem_stolen.c
··· 89 89 mutex_unlock(&dev_priv->mm.stolen_lock); 90 90 } 91 91 92 - static unsigned long i915_stolen_to_physical(struct drm_device *dev) 92 + static unsigned long i915_stolen_to_physical(struct drm_i915_private *dev_priv) 93 93 { 94 - struct drm_i915_private *dev_priv = to_i915(dev); 95 94 struct pci_dev *pdev = dev_priv->drm.pdev; 96 95 struct i915_ggtt *ggtt = &dev_priv->ggtt; 97 96 struct resource *r; ··· 252 253 * kernel. So if the region is already marked as busy, something 253 254 * is seriously wrong. 254 255 */ 255 - r = devm_request_mem_region(dev->dev, base, ggtt->stolen_size, 256 + r = devm_request_mem_region(dev_priv->drm.dev, base, ggtt->stolen_size, 256 257 "Graphics Stolen Memory"); 257 258 if (r == NULL) { 258 259 /* ··· 263 264 * PCI bus, but have an off-by-one error. Hence retry the 264 265 * reservation starting from 1 instead of 0. 265 266 */ 266 - r = devm_request_mem_region(dev->dev, base + 1, 267 + r = devm_request_mem_region(dev_priv->drm.dev, base + 1, 267 268 ggtt->stolen_size - 1, 268 269 "Graphics Stolen Memory"); 269 270 /* ··· 407 408 *size = stolen_top - *base; 408 409 } 409 410 410 - int i915_gem_init_stolen(struct drm_device *dev) 411 + int i915_gem_init_stolen(struct drm_i915_private *dev_priv) 411 412 { 412 - struct drm_i915_private *dev_priv = to_i915(dev); 413 413 struct i915_ggtt *ggtt = &dev_priv->ggtt; 414 414 unsigned long reserved_total, reserved_base = 0, reserved_size; 415 415 unsigned long stolen_top; ··· 416 418 mutex_init(&dev_priv->mm.stolen_lock); 417 419 418 420 #ifdef CONFIG_INTEL_IOMMU 419 - if (intel_iommu_gfx_mapped && INTEL_INFO(dev)->gen < 8) { 421 + if (intel_iommu_gfx_mapped && INTEL_GEN(dev_priv) < 8) { 420 422 DRM_INFO("DMAR active, disabling use of stolen memory\n"); 421 423 return 0; 422 424 } ··· 425 427 if (ggtt->stolen_size == 0) 426 428 return 0; 427 429 428 - dev_priv->mm.stolen_base = i915_stolen_to_physical(dev); 430 + dev_priv->mm.stolen_base = i915_stolen_to_physical(dev_priv); 429 431 if (dev_priv->mm.stolen_base == 0) 430 432 return 0; 431 433