Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

phy: exynos: Use one define for enable bit

There is no need for separate defines for Exynos4 and Exynos5 phy enable
bit and MIPI phy reset bits. In both cases there are the same so
simplify it.

This reduces number of defines and allows removal of one header file.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Lee Jones <lee.jones@linaro.org>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

authored by

Krzysztof Kozlowski and committed by
Kishon Vijay Abraham I
7a66647b 33e9a6aa

+25 -27
+2 -3
drivers/phy/phy-exynos-dp-video.c
··· 14 14 #include <linux/kernel.h> 15 15 #include <linux/module.h> 16 16 #include <linux/mfd/syscon.h> 17 - #include <linux/mfd/syscon/exynos5-pmu.h> 18 17 #include <linux/of.h> 19 18 #include <linux/of_address.h> 20 19 #include <linux/phy/phy.h> ··· 36 37 37 38 /* Disable power isolation on DP-PHY */ 38 39 return regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset, 39 - EXYNOS5_PHY_ENABLE, EXYNOS5_PHY_ENABLE); 40 + EXYNOS4_PHY_ENABLE, EXYNOS4_PHY_ENABLE); 40 41 } 41 42 42 43 static int exynos_dp_video_phy_power_off(struct phy *phy) ··· 45 46 46 47 /* Enable power isolation on DP-PHY */ 47 48 return regmap_update_bits(state->regs, state->drvdata->phy_ctrl_offset, 48 - EXYNOS5_PHY_ENABLE, 0); 49 + EXYNOS4_PHY_ENABLE, 0); 49 50 } 50 51 51 52 static const struct phy_ops exynos_dp_video_phy_ops = {
+19 -20
drivers/phy/phy-exynos-mipi-video.c
··· 12 12 #include <linux/err.h> 13 13 #include <linux/io.h> 14 14 #include <linux/kernel.h> 15 - #include <linux/mfd/syscon/exynos5-pmu.h> 16 15 #include <linux/module.h> 17 16 #include <linux/of.h> 18 17 #include <linux/of_address.h> ··· 63 64 { 64 65 /* EXYNOS_MIPI_PHY_ID_CSIS0 */ 65 66 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM0, 66 - .enable_val = EXYNOS4_MIPI_PHY_ENABLE, 67 + .enable_val = EXYNOS4_PHY_ENABLE, 67 68 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(0), 68 69 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 69 70 .resetn_val = EXYNOS4_MIPI_PHY_SRESETN, ··· 72 73 }, { 73 74 /* EXYNOS_MIPI_PHY_ID_DSIM0 */ 74 75 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS0, 75 - .enable_val = EXYNOS4_MIPI_PHY_ENABLE, 76 + .enable_val = EXYNOS4_PHY_ENABLE, 76 77 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(0), 77 78 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 78 79 .resetn_val = EXYNOS4_MIPI_PHY_MRESETN, ··· 81 82 }, { 82 83 /* EXYNOS_MIPI_PHY_ID_CSIS1 */ 83 84 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM1, 84 - .enable_val = EXYNOS4_MIPI_PHY_ENABLE, 85 + .enable_val = EXYNOS4_PHY_ENABLE, 85 86 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(1), 86 87 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 87 88 .resetn_val = EXYNOS4_MIPI_PHY_SRESETN, ··· 90 91 }, { 91 92 /* EXYNOS_MIPI_PHY_ID_DSIM1 */ 92 93 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS1, 93 - .enable_val = EXYNOS4_MIPI_PHY_ENABLE, 94 + .enable_val = EXYNOS4_PHY_ENABLE, 94 95 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(1), 95 96 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 96 97 .resetn_val = EXYNOS4_MIPI_PHY_MRESETN, ··· 108 109 { 109 110 /* EXYNOS_MIPI_PHY_ID_CSIS0 */ 110 111 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM0, 111 - .enable_val = EXYNOS5_PHY_ENABLE, 112 + .enable_val = EXYNOS4_PHY_ENABLE, 112 113 .enable_reg = EXYNOS5420_MIPI_PHY_CONTROL(0), 113 114 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 114 - .resetn_val = EXYNOS5_MIPI_PHY_S_RESETN, 115 + .resetn_val = EXYNOS4_MIPI_PHY_SRESETN, 115 116 .resetn_reg = EXYNOS5420_MIPI_PHY_CONTROL(0), 116 117 .resetn_map = EXYNOS_MIPI_REGMAP_PMU, 117 118 }, { 118 119 /* EXYNOS_MIPI_PHY_ID_DSIM0 */ 119 120 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS0, 120 - .enable_val = EXYNOS5_PHY_ENABLE, 121 + .enable_val = EXYNOS4_PHY_ENABLE, 121 122 .enable_reg = EXYNOS5420_MIPI_PHY_CONTROL(0), 122 123 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 123 - .resetn_val = EXYNOS5_MIPI_PHY_M_RESETN, 124 + .resetn_val = EXYNOS4_MIPI_PHY_MRESETN, 124 125 .resetn_reg = EXYNOS5420_MIPI_PHY_CONTROL(0), 125 126 .resetn_map = EXYNOS_MIPI_REGMAP_PMU, 126 127 }, { 127 128 /* EXYNOS_MIPI_PHY_ID_CSIS1 */ 128 129 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM1, 129 - .enable_val = EXYNOS5_PHY_ENABLE, 130 + .enable_val = EXYNOS4_PHY_ENABLE, 130 131 .enable_reg = EXYNOS5420_MIPI_PHY_CONTROL(1), 131 132 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 132 - .resetn_val = EXYNOS5_MIPI_PHY_S_RESETN, 133 + .resetn_val = EXYNOS4_MIPI_PHY_SRESETN, 133 134 .resetn_reg = EXYNOS5420_MIPI_PHY_CONTROL(1), 134 135 .resetn_map = EXYNOS_MIPI_REGMAP_PMU, 135 136 }, { 136 137 /* EXYNOS_MIPI_PHY_ID_DSIM1 */ 137 138 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS1, 138 - .enable_val = EXYNOS5_PHY_ENABLE, 139 + .enable_val = EXYNOS4_PHY_ENABLE, 139 140 .enable_reg = EXYNOS5420_MIPI_PHY_CONTROL(1), 140 141 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 141 - .resetn_val = EXYNOS5_MIPI_PHY_M_RESETN, 142 + .resetn_val = EXYNOS4_MIPI_PHY_MRESETN, 142 143 .resetn_reg = EXYNOS5420_MIPI_PHY_CONTROL(1), 143 144 .resetn_map = EXYNOS_MIPI_REGMAP_PMU, 144 145 }, { 145 146 /* EXYNOS_MIPI_PHY_ID_CSIS2 */ 146 147 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, 147 - .enable_val = EXYNOS5_PHY_ENABLE, 148 + .enable_val = EXYNOS4_PHY_ENABLE, 148 149 .enable_reg = EXYNOS5420_MIPI_PHY_CONTROL(2), 149 150 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 150 - .resetn_val = EXYNOS5_MIPI_PHY_S_RESETN, 151 + .resetn_val = EXYNOS4_MIPI_PHY_SRESETN, 151 152 .resetn_reg = EXYNOS5420_MIPI_PHY_CONTROL(2), 152 153 .resetn_map = EXYNOS_MIPI_REGMAP_PMU, 153 154 }, ··· 171 172 { 172 173 /* EXYNOS_MIPI_PHY_ID_CSIS0 */ 173 174 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_DSIM0, 174 - .enable_val = EXYNOS5_PHY_ENABLE, 175 + .enable_val = EXYNOS4_PHY_ENABLE, 175 176 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(0), 176 177 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 177 178 .resetn_val = BIT(0), ··· 180 181 }, { 181 182 /* EXYNOS_MIPI_PHY_ID_DSIM0 */ 182 183 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_CSIS0, 183 - .enable_val = EXYNOS5_PHY_ENABLE, 184 + .enable_val = EXYNOS4_PHY_ENABLE, 184 185 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(0), 185 186 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 186 187 .resetn_val = BIT(0), ··· 189 190 }, { 190 191 /* EXYNOS_MIPI_PHY_ID_CSIS1 */ 191 192 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, 192 - .enable_val = EXYNOS5_PHY_ENABLE, 193 + .enable_val = EXYNOS4_PHY_ENABLE, 193 194 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(1), 194 195 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 195 196 .resetn_val = BIT(1), ··· 198 199 }, { 199 200 /* EXYNOS_MIPI_PHY_ID_DSIM1 */ 200 201 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, 201 - .enable_val = EXYNOS5_PHY_ENABLE, 202 + .enable_val = EXYNOS4_PHY_ENABLE, 202 203 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(1), 203 204 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 204 205 .resetn_val = BIT(1), ··· 207 208 }, { 208 209 /* EXYNOS_MIPI_PHY_ID_CSIS2 */ 209 210 .coupled_phy_id = EXYNOS_MIPI_PHY_ID_NONE, 210 - .enable_val = EXYNOS5_PHY_ENABLE, 211 + .enable_val = EXYNOS4_PHY_ENABLE, 211 212 .enable_reg = EXYNOS4_MIPI_PHY_CONTROL(2), 212 213 .enable_map = EXYNOS_MIPI_REGMAP_PMU, 213 214 .resetn_val = BIT(0),
+2 -3
drivers/phy/phy-exynos5-usbdrd.c
··· 22 22 #include <linux/platform_device.h> 23 23 #include <linux/mutex.h> 24 24 #include <linux/mfd/syscon.h> 25 - #include <linux/mfd/syscon/exynos5-pmu.h> 26 25 #include <linux/regmap.h> 27 26 #include <linux/regulator/consumer.h> 28 27 #include <linux/soc/samsung/exynos-regs-pmu.h> ··· 235 236 if (!inst->reg_pmu) 236 237 return; 237 238 238 - val = on ? 0 : EXYNOS5_PHY_ENABLE; 239 + val = on ? 0 : EXYNOS4_PHY_ENABLE; 239 240 240 241 regmap_update_bits(inst->reg_pmu, inst->pmu_offset, 241 - EXYNOS5_PHY_ENABLE, val); 242 + EXYNOS4_PHY_ENABLE, val); 242 243 } 243 244 244 245 /*
+2 -1
include/linux/soc/samsung/exynos-regs-pmu.h
··· 52 52 53 53 /* MIPI_PHYn_CONTROL, valid for Exynos3250, Exynos4, Exynos5250 and Exynos5433 */ 54 54 #define EXYNOS4_MIPI_PHY_CONTROL(n) (0x0710 + (n) * 4) 55 - #define EXYNOS4_MIPI_PHY_ENABLE (1 << 0) 55 + /* Phy enable bit, common for all phy registers, not only MIPI */ 56 + #define EXYNOS4_PHY_ENABLE (1 << 0) 56 57 #define EXYNOS4_MIPI_PHY_SRESETN (1 << 1) 57 58 #define EXYNOS4_MIPI_PHY_MRESETN (1 << 2) 58 59 #define EXYNOS4_MIPI_PHY_RESET_MASK (3 << 1)