Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf lzma: Convert some pr_err() to pr_debug() as callers already use pr_debug()

I noticed some error with:

# perf list ex_ret_brn
lzma: fopen failed on /usr/lib/modules/5.15.14-100.fc34.x86_64/kernel/net/bluetooth/bnep/bnep.ko.xz: 'No such file or directory'
lzma: fopen failed on /usr/lib/modules/5.16.16-200.fc35.x86_64/kernel/drivers/gpu/drm/drm_kms_helper.ko.xz: 'No such file or directory'
lzma: fopen failed on /usr/lib/modules/5.18.16-200.fc36.x86_64/kernel/arch/x86/crypto/crct10dif-pclmul.ko.xz: 'No such file or directory'
lzma: fopen failed on /usr/lib/modules/5.16.16-200.fc35.x86_64/kernel/drivers/i2c/busses/i2c-piix4.ko.xz: 'No such file or directory'
<BIG SNIP>

Then using 'perf probe' + 'perf trace' to debug 'perf list', it seems
its some inconsistency in the ~/.debug/ cache where broken build id
symlinks that ends up making it try to uncompress some kernel modules
using the lzma routines:

395.309 perf/3594447 probe_perf:lzma_decompress_to_file(__probe_ip: 6118448, input_string: "/usr/lib/modules/5.18.17-200.fc36.x86_64/kernel/drivers/nvme/host/nvme.ko.xz")
lzma_decompress_to_file (/var/home/acme/bin/perf)
filename__decompress (/var/home/acme/bin/perf)
filename__read_build_id (/var/home/acme/bin/perf)
filename__sprintf_build_id (inlined)
build_id_cache__valid_id (inlined)
build_id_cache__list_all (/var/home/acme/bin/perf)
print_sdt_events (/var/home/acme/bin/perf)
cmd_list (/var/home/acme/bin/perf)
run_builtin (/var/home/acme/bin/perf)
handle_internal_command (inlined)
run_argv (inlined)
main (/var/home/acme/bin/perf)
__libc_start_call_main (/usr/lib64/libc.so.6)
__libc_start_main@@GLIBC_2.34 (/usr/lib64/libc.so.6)
_start (/var/home/acme/bin/perf)

But callers of filename__decompress() already check its return and use
pr_debug(), so be consistent and make functions it calls also use
pr_debug().

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/lkml/ZOUD0+GkuCVkYF7n@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

+5 -7
+5 -7
tools/perf/util/lzma.c
··· 45 45 46 46 infile = fopen(input, "rb"); 47 47 if (!infile) { 48 - pr_err("lzma: fopen failed on %s: '%s'\n", 49 - input, strerror(errno)); 48 + pr_debug("lzma: fopen failed on %s: '%s'\n", input, strerror(errno)); 50 49 return -1; 51 50 } 52 51 53 52 ret = lzma_stream_decoder(&strm, UINT64_MAX, LZMA_CONCATENATED); 54 53 if (ret != LZMA_OK) { 55 - pr_err("lzma: lzma_stream_decoder failed %s (%d)\n", 56 - lzma_strerror(ret), ret); 54 + pr_debug("lzma: lzma_stream_decoder failed %s (%d)\n", lzma_strerror(ret), ret); 57 55 goto err_fclose; 58 56 } 59 57 ··· 66 68 strm.avail_in = fread(buf_in, 1, sizeof(buf_in), infile); 67 69 68 70 if (ferror(infile)) { 69 - pr_err("lzma: read error: %s\n", strerror(errno)); 71 + pr_debug("lzma: read error: %s\n", strerror(errno)); 70 72 goto err_lzma_end; 71 73 } 72 74 ··· 80 82 ssize_t write_size = sizeof(buf_out) - strm.avail_out; 81 83 82 84 if (writen(output_fd, buf_out, write_size) != write_size) { 83 - pr_err("lzma: write error: %s\n", strerror(errno)); 85 + pr_debug("lzma: write error: %s\n", strerror(errno)); 84 86 goto err_lzma_end; 85 87 } 86 88 ··· 92 94 if (ret == LZMA_STREAM_END) 93 95 break; 94 96 95 - pr_err("lzma: failed %s\n", lzma_strerror(ret)); 97 + pr_debug("lzma: failed %s\n", lzma_strerror(ret)); 96 98 goto err_lzma_end; 97 99 } 98 100 }